Add checking 'const' to Drupal.Semantics.ConstantName.ConstantStart

Open on Drupal.org →

Created on 6 May 2023, almost 2 years ago

Problem/Motivation

Working on core issue, 📌 Fix 'Drupal.Semantics.ConstantName.ConstantStart' coding standard Postponed we realized that this sniff checks constants created with 'define' and not 'const'. Given the name of the sniff that was not expected.

Can the sniff be updated to check 'const' constants or perhaps add a new sniff.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

✨ Feature request

Status

Fixed

Version

8.3

Component

Review/Rules

Created by

🇳🇿New Zealand quietone

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Comments & Activities

Issue created by @quietone
Comment almost 2 years ago →
🇳🇿New Zealand quietone

Comment almost 2 years ago →

klausi → authored 9a152b41 on 8.3.x

feat(ConstName): Support const keyword in constant name prefix detection...

Status changed to Fixed almost 2 years ago10:17am 6 May 2023
Comment almost 2 years ago →
🇦🇹Austria klausi 🇦🇹 Vienna
Thanks for reporting! Pushed a feature for the existing sniff in https://github.com/pfrenssen/coder/pull/200
Comment almost 2 years ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024