Drupal 10 compatibility

Created on 5 May 2023, over 1 year ago

The module in 8.x-1.x-dev branch isn't compatible with Drupal 10.

Here's a patch to make it compatible. We'll need to release this as a new major version, because it drops support for Drupal 8 due to the dependency on Symfony >=4.3 in \Symfony\Component\Mime\MimeTypesInterface

Remaining tasks:
* Manually test the patch with Drupal 10

📌 Task
Status

Active

Version

1.0

Component

Code

Created by

🇬🇧United Kingdom nicrodgers Monmouthshire, UK

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @nicrodgers
  • Status changed to Needs review over 1 year ago
  • 🇬🇧United Kingdom nicrodgers Monmouthshire, UK
  • 🇬🇧United Kingdom nicrodgers Monmouthshire, UK

    Ignore #2, it contains another patch.
    Use this one instead :)

  • 🇪🇸Spain manuel.adan 🌌
    +++ b/src/MimeDetectService.php
    @@ -22,7 +22,7 @@ class MimeDetectService implements MimeDetectServiceInterface {
    +   * @var \Symfony\Component\Mime\MimeTypesInterface
    

    You advert that the MIME type guesser class in symfony >= 4.3 has changed, but MimeTypesInterface is a different interface.

    It was moved to \Symfony\Component\Mime\MimeTypeGuesserInterface and removed from its original location in Symfony 5.0 and their methods renamed.

    Patch reviewed accordingly.

  • Status changed to RTBC 12 months ago
  • 🇬🇧United Kingdom nicrodgers Monmouthshire, UK

    Good spot. Looks good. We've been using patch 4 in production on some high traffic sites for a few weeks now without any issue.

  • First commit to issue fork.
  • Merge request !2Apply patch file... → (Open) created by somersoft
  • Status changed to Needs review 22 days ago
  • 🇬🇧United Kingdom nicrodgers Monmouthshire, UK

    I've updated the MR to declare support for D11, as upgrade status was reporting that everything was compatible with no further changes required. I've hidden the patch files for clarity, the latest code is in the MR.

Production build 0.71.5 2024