With BigPipe, slider with thumbnails doesn't work after upgrade to 2.7

Created on 5 May 2023, about 1 year ago
Updated 6 May 2023, about 1 year ago

Problem/Motivation

I have a slider with navigation

It works fine with 2.6 version. After upgrade to 2.7 navigation doesn't work with error

What commit between 2.6 and 2.7 can break it? Please help how to debug it

💬 Support request
Status

Closed: duplicate

Version

2.7

Component

Miscellaneous

Created by

ivnish Poland

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @ivnish
  • Status changed to Postponed: needs info about 1 year ago
  • 🇮🇩Indonesia gausarts

    Please detail more your setups:

    • Slick library version? See project home requirements.
    • Blazy version? Must be updated to the latest (2.14).
    • Enabling Accessible slick at Slick UI? Disable it.
    • Clear cache?
  • 🇮🇩Indonesia gausarts

    The only obvious breaking change was core removal of jQuery.once which was fixed since Blazy 2.6+. Updating your Blazy should fix it, though.

    Let me know?

  • ivnish Poland

    Thank you for quick response!

    • Slick library is 1.8.0
    • Blazy is 2.14
    • slick_views is 2.6
    • Clear cache of course
    • Accessible slick is disabled
  • ivnish Poland

    The problem is in slick.load.js file. If I copy it from 2.6 to 2.7 it works

  • 🇮🇩Indonesia gausarts

    Most suspects were eliminated :)
    No more idea, yet. Need more details.

    Ignore if OK, assumed:

    • Vanilla disabled?
    • Drupal is the latest, not below D9.3?
    • Slick package.json matches the version written in slick.js?
    • Switch to Bartik, and persisted?

    Please press F12, and inspect element starting from .slick element, and reveal its children: .slick-slider, .slick-list. If they are not there, something else breaks it.

    > Slick Views
    Is the image using Blazy formatter? Try it, if not.

  • 🇮🇩Indonesia gausarts

    > The problem is in slick.load.js file. If I copy it from 2.6 to 2.7 it works
    Ok, as said the only change was jQuery.once removal.

    Likely something else breaks it as I don't have such an issue. Please verify my previous comment #6.

    Also is it in AJAX loaded contents, or plain HTML?

  • ivnish Poland

    Ok, the problem is 13 line in slick.load.js

    2.6

    var _element = '.' + _id + ':not(.' + _mounted + ')';

    2.7

    var _element = '.' + _id;

    I can make a local patch for my site, if this is unfixable

  • 🇮🇩Indonesia gausarts

    Hm, weird that it causes the issue.

    The point of core.once is to eliminate such unnecessarily added classes.

    But if I could reproduce it, why not. That is why I asked you to answer #6, for a repro.

  • ivnish Poland
    • Vanilla is disabled
    • Drupal 9.5
    • Slick package.json matches the version written in slick.js
    • Switch to Bartik, and persisted

    Please press F12, and inspect element starting from .slick element, and reveal its children: .slick-slider, .slick-list. If they are not there, something else breaks it.

    No problem here

    > Slick Views
    Is the image using Blazy formatter? Try it, if not.

    No, but Blazy formatter doesn't help

    Hm, weird that it causes the issue.

    But it's a fact

    I already make a patch. If someone has the same problem, I will attach it here

    But if I could reproduce it, why not.

    I have a content type with image field. I have a views format Slick Carousel and 3 fields from content type. Title, image big, image small. In the slick settings I set Optionset main, Optionset thumbnail, Main stage, thumbnail image and thumbnail caption

  • 🇮🇩Indonesia gausarts

    OK, patches are always welcome even before repros to benefit others in the same boat :)

    Yet my main interest is more about a repro for the project issue validity and accountability.

    No repros no bugs, simply to set real issues aside from user errors, or worse unhealthy error gamings seen everywhere. Of course, without neglecting genuine ones. I would never call any error reports gaming, that is unfriendly, but I always insisted a repro and genuine one, and am open to corrections if proven properly.

    If I couldn't reproduce it at all, it should at least make sense to my designated programs.

    Thanks.

  • ivnish Poland

    Ok, I attached a patch for others in the same boat :)

  • ivnish Poland

    Thanks for your help. Try to reproduce it, if you have time

  • Status changed to Needs review about 1 year ago
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.0.7 + Environment: PHP 7.4 & MySQL 5.7
    last update about 1 year ago
    Composer require failure
  • 🇮🇩Indonesia gausarts

    Got it, thanks. Let's see if anyone else out of 21k installs are having this and could kindly educate me more with a repro :)

  • 🇮🇩Indonesia gausarts

    Having a patch under a Supports without Bugs or Tasks is uncommon :)

    Assumed a regression bug, till proven otherwise.

  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.0 & MySQL 5.7
    last update about 1 year ago
    19 pass
  • 🇮🇩Indonesia gausarts

    Regading #13 failing tests for D10 with PHP7, somebody more involved should kindly report it to Drupal core to not use or remove PHP7 for D10 as a default bot since D10 requires PHP8 in the first place :)

  • 🇮🇩Indonesia gausarts

    Wait, I forgot my favorite scapegoat.

    Is Big Pipe enabled?
    If yes, try disabling it, and see if persisted. If no, no worries, we'll find another one till it ends on me :)

  • ivnish Poland

    Yes, BigPipe is enabled.

    Yes, without BigPipe it works.

  • Status changed to Closed: duplicate about 1 year ago
  • 🇮🇩Indonesia gausarts

    > Yes, without BigPipe it works.
    Gotcha.

    Just noticed, this one is a dup. Closing it now.

    Kindly move your patch here: 📌 Incompatibility with BigPipe? Fixed .

    And we'll commit it there to help minimize BigPipe compatibility issues. Waiting for core to resolve normally takes years, contribs months.

    See comment #3 📌 Incompatibility with BigPipe? Fixed there for details.

    Thanks.

Production build 0.69.0 2024