- Issue created by @hmdnawaz
- last update
over 1 year ago 32 pass - last update
over 1 year ago 32 pass - @hmdnawaz opened merge request.
- Status changed to Needs review
over 1 year ago 10:36am 3 May 2023 - πͺπ¨Ecuador jwilson3
Is there an explicit reason why not to use accessCheck(TRUE), which is what is recommended to use by default? does TRUE break something? If not, I'd suggest starting with trying TRUE in most cases to get it committed, and then continue testing and if it breaks something, create a follow-up issue in the future.
- Status changed to Needs work
over 1 year ago 6:52pm 3 May 2023 - π΅π°Pakistan hmdnawaz
We need to load all the entities which is why accessCheck(FALSE) is added. Do we need to load only the entities the user has access to? If yes in that case we need to use the accessCheck(TRUE).
- πͺπ¨Ecuador jwilson3
Thanks for the explanation. It makes sense, particularly after looking at more of the context in the diff:
https://git.drupalcode.org/project/address/-/merge_requests/26/diffs
I've updated the issue summary to explain the choice of why to use FALSE in the Access Check condition.
- Status changed to RTBC
over 1 year ago 3:13pm 4 May 2023 - πͺπ¨Ecuador jwilson3
Raising this to Major since it throws a fatal error in Drupal 10.
-
bojanz β
committed 1662d954 on 8.x-1.x authored by
hmdnawaz β
Issue #3357838: Relying on entity queries to check access by default is...
-
bojanz β
committed 1662d954 on 8.x-1.x authored by
hmdnawaz β
- Status changed to Fixed
over 1 year ago 3:18pm 4 May 2023 Automatically closed - issue fixed for 2 weeks with no activity.