- Issue created by @freelock
- Status changed to Needs review
over 1 year ago 5:55am 3 May 2023 - last update
over 1 year ago Patch Failed to Apply - Status changed to RTBC
over 1 year ago 7:31am 4 May 2023 - ๐ฎ๐ณIndia Kaustab_Roy
Faced same issue of php errors: Deprecated function: DOMElement::setAttribute():โฆ
patch#2 Applied cleanly
Errors are gone.Thanks.
- Status changed to Needs work
about 1 year ago 2:23am 11 September 2023 - ๐ช๐จEcuador jwilson3
Patch did not apply to latest 2.2.x branch, therefore I've manually rerolled it.
The code change looks good, but haven't had a chance to test this personally.
Also, it would be good to have written tests for it.
- ๐ช๐จEcuador jwilson3
I am reclassifying this as an actual bug, because this situation generates a deprecated message in Drupal 10 if one of the two items is non-empty while the other is left empty:
Deprecated function: DOMElement::setAttribute(): Passing null to parameter #2 ($value) of type string is deprecated in Drupal\svg_image_field\Plugin\Field\FieldFormatter\SvglmageFieldFormatter- โบloadinlineSvgData() (line 345 of /var/www/html/src/Plugin/Field/FieldFormatter/SvglmageFieldFormatter.php).
-
jwilson3 โ
committed 580cd70e on 2.3.x
Issue #3357806 by freelock, jwilson3: Cannot set height without width or...
-
jwilson3 โ
committed 580cd70e on 2.3.x
- Status changed to Fixed
about 1 year ago 8:51am 21 September 2023 Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
about 1 year ago 3:40am 13 October 2023