- Issue created by @codebymikey
- Merge request !37Issue #3357652: Allow the idlist option to work on the primary ID of source plugins containing multiple IDs → (Open) created by codebymikey
- last update
over 1 year ago 37 pass, 2 fail - last update
over 1 year ago 38 pass - Status changed to Needs review
over 1 year ago 2:53pm 14 July 2023 - last update
over 1 year ago 38 pass - heddn Nicaragua
+++ b/src/Drush/MigrateToolsCommands.php @@ -1053,7 +1053,7 @@ class MigrateToolsCommands extends DrushCommands { } +++ b/src/SourceFilter.php @@ -130,4 +215,54 @@ class SourceFilter extends \FilterIterator implements MigrateSourceInterface { + $method = new \ReflectionMethod($map, 'getIterator');
I don't see where we call
getIterator
. I'm missing why this is needed. Not sure if it's worth merging the 5.x ✨ Allow the idlist option to work on the primary ID of source plugins containing multiple IDs Needs work and 6.x issues together.
But the same feedback has been addressed here
- heddn Nicaragua
Can we add some of the "why as comments into the code so we will remember why wacky is needed?
Added a rebased patch targetting 6.0.x.
And sorry for the lack of update on this, but haven't had the time to implement the feedback.