- Issue created by @franceslui
- Status changed to Needs review
over 1 year ago 10:47pm 1 May 2023 - 🇨🇦Canada franceslui
To fix the issue, I have modified the function _resource_conflict_get_timespans so that $start and $end are always strings. Please see my attached patch. Thank you.
- 🇨🇦Canada joelpittet Vancouver
@franceslui, thanks for the patch, I think the logic is sound. I'm a bit worried about the method calls on the parenthesis object.
We can enforce a PHP version to PHP 5.4:
https://3v4l.org/RCDIJ#v5.4.0
But it fails on PHP 5.3.3 ( Minimum D7 version → )
https://3v4l.org/RCDIJ#v5.3.3I do think it's reasonable to move PHP up, and considering most people will not be using PHP 5.3 (or I hope not).
So the question to you is should we enforce PHP >= 5.4.0 in our info file. Or change the patch to move the object to a variable and leave the compatibility alone?
- 🇨🇦Canada franceslui
@ joelpittet Thank you so much for pointing out that my previously submitted patch was not compatible with PHP 5.3.3. I don't think we should enforce PHP >= 5.4.0 in your info file because doing so may make other people's sites not working.
I have submitted a new patch that should have no compatibility issues. Please see the attached. Thank you.
- 🇨🇦Canada joelpittet Vancouver
Thank you @franceslui, I've committed this to the dev branch for a new release
- Status changed to Fixed
over 1 year ago 7:01pm 2 May 2023 -
joelpittet →
committed 1f6bb9fc on 7.x-3.x authored by
franceslui →
Issue #3357549 by franceslui, joelpittet: PDOException is thrown when...
-
joelpittet →
committed 1f6bb9fc on 7.x-3.x authored by
franceslui →
Automatically closed - issue fixed for 2 weeks with no activity.