Created on 30 April 2023, over 1 year ago
Updated 14 June 2023, over 1 year ago

Problem/Motivation

@brianperry and I were able to meet face to face to have a design review and talk about what work we would need to do in order to stabilize Same Page Preview for Phase 2 before we start thinking about Phase 3.

To Summarize:

  1. A few more features
  2. Reorganize settings (both in admin and in preview widget)
  3. Have a path to stabilize the model so it can get into production sites.

In detail we want to:

  • Consolidate / move all features that effect how the preview looks / behaves to inside the preview
  • Refactor / Reduce the buttons to minimize horizontal real estate.
  • Implement a full screen button
  • Implement a gear button to contain settings for our local settings options.
  • Allow for "advanced settings" of: hide/show view mode drop down, hide/show all the things basically
  • Rethink how settings are organized placed in general
  • Allow Drupal's preview button to appear again, have that trigger the reveal of the same page preview if permitted to appear & collapsed.

Proposed resolution

Use this issue as a meta for these pursuits, talk again about these objectives during next Bi-weekly meeting.

Remaining tasks

All the aboe.

User interface changes

Yep

API changes

Yep

Data model changes

✨ Feature request
Status

Fixed

Version

2.0

Component

Plan

Created by

πŸ‡ΊπŸ‡ΈUnited States cosmicdreams Minneapolis/St. Paul

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @cosmicdreams
  • πŸ‡¨πŸ‡¦Canada mandclu

    Allow Drupal's preview button to appear again, have that trigger the reveal of the same page preview if permitted to appear & collapsed.

    I really like this idea, thought I do have two reservations:

    • In any admin theme except Gin, the Preview button is at the bottom of the form, and offering authors the option to see a live preview after they've populated all the fields would seriously diminish the value. Is there a way it could only rely on the existing button if it is in a fixed position container?
    • I think it's worth discussion if "Preview" is still the most appropriate label given the altered functionality. For example, would "Live Preview" better communicate what a content author should expect?

    Also, it hasn't been as explicitly mentioned here, but I believe that in one of the Slack threads there was mention that the setting of the localStorage preference about whether or not to use the preview pane by default would be moved to the gear icon. My personal view is that this would be a mistake. I think we should be careful not to assume that users will use the gear icon at all.

    Personally I would favour using localStorage to treat every user choice as persistent, and then use the options within the gear icon as a way to expose less obvious options, and maybe a more explicit way to manage the stored preferences.

  • πŸ‡ΊπŸ‡ΈUnited States brianperry

    > In any admin theme except Gin, the Preview button is at the bottom of the form, and offering authors the option to see a live preview after they've populated all the fields would seriously diminish the value. Is there a way it could only rely on the existing button if it is in a fixed position container?

    In early iterations we had altered the node edit form to ensure the preview button was at the top. In fact, I think we may have displayed it at both the top and bottom. We could consider something similar with this change.

  • πŸ‡ΊπŸ‡ΈUnited States brianperry

    Maybe a stretch goal, but I believe we also discussed trying to address https://www.drupal.org/project/same_page_preview/issues/3345096 πŸ“Œ Add a grabber to the left border of the dialog Postponed (making it clearer that the preview panel can be dragged) as part of this as well.

  • πŸ‡ΊπŸ‡ΈUnited States cosmicdreams Minneapolis/St. Paul

    The intent of the module remains to have the preview on/open by default. In that context, we can understand that clicking the preview button to open the preview is limited for the case when the user has chosen to turn the live preview off and only wants to see it when they choose to.

    All of that considered, it is understandable that having a singular preview button at the bottom of the page would be fine

  • πŸ‡ΊπŸ‡ΈUnited States cosmicdreams Minneapolis/St. Paul

    Personally I would favour using localStorage to treat every user choice as persistent, and then use the options within the gear icon as a way to expose less obvious options, and maybe a more explicit way to manage the stored preferences

    It sounds like you only object to having the on by default setting available in the "advanced settings" menu option that is planned in the gear issue. The gear's intent is to make it easier to customize the preview experience. These quick feature toggles all feel like they belong together. It would feel weird to exclude on by default while keeping toggles for the UI elements.

    We also have received feedback that the entire decision of including local settings might be contentious when including this feature into Core. I think rolling all these customizations into one feature helps us make a strong argument for its inclusion.

  • @brianperry opened merge request.
  • πŸ‡ΊπŸ‡ΈUnited States cosmicdreams Minneapolis/St. Paul

    Looks good

  • πŸ‡ΊπŸ‡ΈUnited States cosmicdreams Minneapolis/St. Paul

    Keeping the issue open for future conversations / considerations about finishing 2.1

  • Status changed to Fixed over 1 year ago
  • πŸ‡ΊπŸ‡ΈUnited States cosmicdreams Minneapolis/St. Paul

    2.1 was delivered.

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024