- Issue created by @mxh
- 🇩🇪Germany mxh Offenburg
This is probably not that hard to realize, as we'd basically just need to strip out the brackets from beginning and end, if they are available.
- 🇩🇪Germany jurgenhaas Gottmadingen
It's a great idea to improve UX at this point. I'd like to throw an alternative approach in: instead of being more tolerant with an officially not supported syntax, we could apply validation to token name fields, which would give the user straight feedback about the error and let them correct their model and learn from it for the future.
This would also prevent an awkward situation where someone would use
[field_name:0:value]
as the field name, where the silent correction would try working withfield_name:0:value
to still not satisfy the user as it causes different errors. - 🇩🇪Germany mxh Offenburg
Sure, throwing a validation error instead, that's even better.
- Assigned to jurgenhaas
- 🇩🇪Germany jurgenhaas Gottmadingen
Implemented by using the proposed form field property
#eca_token_reference
as proposed in ✨ Tag form fields that support tokens Active . - Issue was unassigned.
- Status changed to Needs review
over 1 year ago 3:41pm 13 June 2023 - last update
over 1 year ago 287 pass - @jurgenhaas opened merge request.
- Assigned to danielspeicher
- Status changed to Needs work
over 1 year ago 3:18pm 14 June 2023 - 🇩🇪Germany danielspeicher Steisslingen
That is really cool. I think I can provide a test here. At least I give it a try.
- last update
over 1 year ago 289 pass - Status changed to Needs review
over 1 year ago 8:44am 15 June 2023 - 🇩🇪Germany danielspeicher Steisslingen
I have added a new test class for ECA entity.
Of course there is much more to test, but let us do this in other issues. The functionality implemented here in the issue is tested now.
The code here looks good to me.
- last update
over 1 year ago 289 pass - last update
over 1 year ago 289 pass -
jurgenhaas →
committed 7d119ed1 on 1.2.x
Issue #3357267 by jurgenhaas, danielspeicher, mxh: Add token syntax...
-
jurgenhaas →
committed 7d119ed1 on 1.2.x
- Issue was unassigned.
- Status changed to RTBC
over 1 year ago 9:15am 16 June 2023 - 🇩🇪Germany jurgenhaas Gottmadingen
Nice test, thanks @danielspeicher
Merged the MR and now wonder if this should be back ported? It doesn't really change the ECA functionality, it "just" improves the UX while building models.
-
jurgenhaas →
committed 32cb45d9 on 1.1.x
Issue #3357267 by jurgenhaas, danielspeicher, mxh: Add token syntax...
-
jurgenhaas →
committed 32cb45d9 on 1.1.x
- Status changed to Fixed
over 1 year ago 1:43pm 22 June 2023 Automatically closed - issue fixed for 2 weeks with no activity.