Ensure ModeratedNodeListBuilder::getEntityRevisionIds has sufficient test coverage

Created on 28 April 2023, over 1 year ago

Problem/Motivation

In 📌 Fix PHPStan L1 error "Relying on entity queries to check access by default is deprecated..." Fixed we discovered that \Drupal\content_moderation\ModeratedNodeListBuilder::getEntityRevisionIds is either not sufficiently tested, or even completely untested.

I was wrong about the content moderation list builder, it should be TRUE, because it's a list builder so destined for the UI, made a commit to the MR to change it back. The fact we're not getting a deprecation error from that one on tests means that method is likely completely untested (or if not something else is wrong), so tagging for a follow-up.

Steps to reproduce

Proposed resolution

Make sure \Drupal\content_moderation\ModeratedNodeListBuilder::getEntityRevisionIds has sufficient test coverage.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

📌 Task
Status

Active

Version

10.1

Component
Content moderation 

Last updated 2 days ago

Created by

🇳🇱Netherlands spokje

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024