- Issue created by @phenaproxima
- Assigned to phenaproxima
- last update
over 1 year ago Custom Commands Failed - @phenaproxima opened merge request.
- Assigned to wim leers
- Status changed to Needs review
over 1 year ago 7:15pm 26 April 2023 - πΊπΈUnited States phenaproxima Massachusetts
I think I'm happy enough with this.
- last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago 758 pass - Issue was unassigned.
- Status changed to RTBC
over 1 year ago 7:41am 27 April 2023 - Assigned to phenaproxima
- Status changed to Needs work
over 1 year ago 7:44am 27 April 2023 - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Actually, there's one thing missing: we need to update
\Drupal\package_manager\Validator\ComposerValidator::validate()
accordingly? - Assigned to wim leers
- Status changed to Needs review
over 1 year ago 4:18pm 27 April 2023 - πΊπΈUnited States phenaproxima Massachusetts
I thought about that...but I didn't see any real need. The error messages that come back from the validator explain everything that the updated hook_help does, with the same links to Composer's documentation. What sort of changes were you imagining?
- Assigned to phenaproxima
- Status changed to RTBC
over 1 year ago 9:28am 28 April 2023 - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
I was just thinking that now it's inconsistent: one kind of problem provides no detailed explanation and points you to
hook_help()
, the other does not.But you're right that the message in HEAD that points one to
hook_help()
is much more complicated to explain, which justifies that link. That same justification is less possible here.It could be as simple as adding
See <a href=":package-manager-help">the help page</a> for information on how to configure Composer to download packages securely.
I don't think that'd be harmful? Because the help page does actually give you the Composer commands directly!So: RTBC, and I'll let you decide whether it's worth being consistent or not.
- last update
over 1 year ago 762 pass - Status changed to Needs work
over 1 year ago 1:36pm 28 April 2023 - πΊπΈUnited States phenaproxima Massachusetts
Decided to go for consistency. It's helpful, I think, to link to the actual commands where possible.
- last update
over 1 year ago Custom Commands Failed - Assigned to wim leers
- Status changed to Needs review
over 1 year ago 3:02pm 28 April 2023 - Assigned to tedbow
- Assigned to phenaproxima
- πΊπΈUnited States tedbow Ithaca, NY, USA
I am reviewing but assigning to @phenaproxima to fix the unknown word issue.
- Status changed to Needs work
over 1 year ago 5:10pm 1 May 2023 - last update
over 1 year ago 764 pass - Assigned to tedbow
- Status changed to RTBC
over 1 year ago 12:03pm 2 May 2023 - last update
over 1 year ago Custom Commands Failed - Issue was unassigned.
- Status changed to Needs work
over 1 year ago 12:48pm 2 May 2023 - πΊπΈUnited States phenaproxima Massachusetts
Still needs a follow-up. And coding standards checks are failing.
- πΊπΈUnited States tedbow Ithaca, NY, USA
Looks good, just a couple small suggestions
- last update
over 1 year ago 764 pass - last update
over 1 year ago 764 pass - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Linking the issue @phenaproxima created to fix the pre-existing bug @tedbow spotted in reviews.
- last update
over 1 year ago 767 pass - Status changed to RTBC
over 1 year ago 10:13am 4 May 2023 - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Follow-up was created, nits addressed, tests are present. This is ready!
- last update
over 1 year ago 767 pass - last update
over 1 year ago 767 pass -
phenaproxima β
committed 24620958 on 3.0.x
Issue #3356638 by phenaproxima, Wim Leers, tedbow: Improve hook_help()...
-
phenaproxima β
committed 24620958 on 3.0.x
- Status changed to Fixed
over 1 year ago 12:33pm 4 May 2023 Automatically closed - issue fixed for 2 weeks with no activity.