- Issue created by @Grimreaper
- Assigned to Grimreaper
- 🇫🇷France pdureau Paris
Indeed, it is kind of sad to add a setting which will be used by only one variant.
However, we can accept this situation and add an explicit note in the setting description, like what was already done for
image_position
: "Only for default variant."https://git.drupalcode.org/project/ui_suite_bootstrap/-/blob/5.0.x/templ...
- @grimreaper opened merge request.
- Assigned to pdureau
- Status changed to Needs review
over 1 year ago 11:59am 4 May 2023 - 🇫🇷France Grimreaper France 🇫🇷
I hesitated to also add a setting for the "row g-0" div, but I think this one is a "structural" part of the horizontal variant. So no setting for this div.
- Assigned to Grimreaper
- 🇫🇷France pdureau Paris
I would not add such a setting because I agree with "this one is structural part of the horizontal variant"
- Assigned to pdureau
- 🇫🇷France Grimreaper France 🇫🇷
Thanks,
And about the rest of the MR, is it ok for you?
- Assigned to Grimreaper
- Status changed to Needs work
over 1 year ago 9:18am 7 May 2023 - 🇫🇷France pdureau Paris
Why 2 settings? content_col_classes is always 12 minus the value of image_col_classes, isn't it?
- Assigned to pdureau
- 🇫🇷France Grimreaper France 🇫🇷
Yes, but I wanted to give the possibility to handle other breakpoints with, sm, xl, xxl, etc.
- Assigned to Grimreaper
- Status changed to RTBC
over 1 year ago 6:11am 12 May 2023 -
Grimreaper →
committed fd2a3afd on 5.0.x
Issue #3356633 by Grimreaper, pdureau: Pattern card: add settings for...
-
Grimreaper →
committed fd2a3afd on 5.0.x
- Issue was unassigned.
- Status changed to Fixed
over 1 year ago 8:13am 12 May 2023 Automatically closed - issue fixed for 2 weeks with no activity.