Fix the issues reported by phpcs

Created on 26 April 2023, over 1 year ago

Problem/Motivation

FILE: ...\xampp\htdocs\backendassignment\web\modules\contrib\hospital_price_transparency\hospital_price_transparency.module
------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
91 | ERROR | [x] Opening brace should be on the same line as the declaration
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------

FILE: ...p\htdocs\backendassignment\web\modules\contrib\hospital_price_transparency\hospital_price_transparency.routing.yml
------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
22 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
------------------------------------------------------------------------------------------------------------------------

FILE: ...pp\htdocs\backendassignment\web\modules\contrib\hospital_price_transparency\hospital_price_transparency.tokens.inc
------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
22 | WARNING | [x] A comma should follow the last multiline array item. Found: 'url'
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------

FILE: ...dassignment\web\modules\contrib\hospital_price_transparency\src\Controller\HospitalPriceTransparencyController.php
------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------

FILE: ...\htdocs\backendassignment\web\modules\contrib\hospital_price_transparency\src\Entity\HospitalPriceTransparency.php
------------------------------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 4 LINES
------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
234 | ERROR | [ ] Description for the @return value is missing
246 | ERROR | [x] Doc comment short description must end with a full stop
248 | ERROR | [x] Expected "Drupal\file\FileInterface|null" but found "Drupal\file\FileInterface|NULL" for function
| | return type
248 | ERROR | [ ] Description for the @return value is missing
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------

FILE: ...tdocs\backendassignment\web\modules\contrib\hospital_price_transparency\src\Form\HospitalPriceTransparencyForm.php
------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------

FILE: ...ckendassignment\web\modules\contrib\hospital_price_transparency\src\Form\HospitalPriceTransparencySettingsForm.php
------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
35 | ERROR | [ ] The array declaration extends to column 241 (the limit is 80). The array content should be split up
| | over multiple lines
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------

FILE: ...ndassignment\web\modules\contrib\hospital_price_transparency\src\HospitalPriceTransparencyAccessControlHandler.php
------------------------------------------------------------------------------------------------------------------------
FOUND 14 ERRORS AND 1 WARNING AFFECTING 15 LINES
------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
11 | WARNING | [ ] Line exceeds 80 characters; contains 86 characters
27 | ERROR | [x] Case breaking statements must be followed by a single blank line
29 | ERROR | [ ] The array declaration extends to column 88 (the limit is 80). The array content should be split up
| | over multiple lines
31 | ERROR | [x] Each PHP statement must be on a line by itself
34 | ERROR | [x] Case breaking statements must be followed by a single blank line
36 | ERROR | [ ] The array declaration extends to column 90 (the limit is 80). The array content should be split up
| | over multiple lines
38 | ERROR | [x] Each PHP statement must be on a line by itself
41 | ERROR | [x] Case breaking statements must be followed by a single blank line
43 | ERROR | [ ] The array declaration extends to column 90 (the limit is 80). The array content should be split up
| | over multiple lines
45 | ERROR | [x] Each PHP statement must be on a line by itself
48 | ERROR | [x] Case breaking statements must be followed by a single blank line
50 | ERROR | [ ] The array declaration extends to column 88 (the limit is 80). The array content should be split up
| | over multiple lines
52 | ERROR | [x] Each PHP statement must be on a line by itself
67 | ERROR | [ ] The array declaration extends to column 86 (the limit is 80). The array content should be split up
| | over multiple lines
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 9 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------

FILE: ...tdocs\backendassignment\web\modules\contrib\hospital_price_transparency\src\HospitalPriceTransparencyInterface.php
------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------

FILE: ...ocs\backendassignment\web\modules\contrib\hospital_price_transparency\src\HospitalPriceTransparencyListBuilder.php
------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------

FILE: ...mpp\htdocs\backendassignment\web\modules\contrib\hospital_price_transparency\templates\field--hpt--label.html.twig
------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
39 | ERROR | [x] Expected 1 newline at end of file; 2 found
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------

FILE: ...dassignment\web\modules\contrib\hospital_price_transparency\tests\src\Functional\HospitalPriceTransparencyTest.php
------------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AND 1 WARNING AFFECTING 5 LINES
------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
18 | WARNING | [x] '@todo: Remove when we no longer support D9 at all.' should match the format '@todo Fix problem X
| | here.'
19 | ERROR | [ ] Missing @var tag in member variable comment
20 | ERROR | [ ] Do not disable strict config schema checking in tests. Instead ensure your module properly declares
| | its schema for configurations.
64 | ERROR | [x] Expected one space after the comma, 0 found
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------

FILE: ...pp\htdocs\backendassignment\web\modules\contrib\hospital_price_transparency\tests\src\Kernel\HptValidationTest.php
------------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AND 1 WARNING AFFECTING 5 LINES
------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
19 | WARNING | [x] '@todo: Remove when we no longer support D9 at all.' should match the format '@todo Fix problem X
| | here.'
20 | ERROR | [ ] Missing @var tag in member variable comment
21 | ERROR | [ ] Do not disable strict config schema checking in tests. Instead ensure your module properly declares
| | its schema for configurations.
44 | ERROR | [ ] The array declaration extends to column 104 (the limit is 80). The array content should be split up
| | over multiple lines
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------

Time: 2.67 secs; Memory: 6MB

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task
Status

Closed: won't fix

Version

1.0

Component

Code

Created by

🇮🇳India sidharth_soman Bangalore

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @sidharth_soman
  • @sidharth_soman opened merge request.
  • Issue was unassigned.
  • Status changed to Needs review over 1 year ago
  • 🇮🇳India sidharth_soman Bangalore

    Fixed all the issues except for those relating to documentation which should be ideally resolved by the maintainers themselves. Keeping the array declarations as it is due to readability too.

    Please review the MR.

  • Status changed to Closed: won't fix over 1 year ago
  • 🇺🇸United States danflanagan8 St. Louis, US

    This is the second worthless issue I've received from Valuebound developers. This project has almost no usages, which means that issue credits do not help Valuebound in the Marketplace rankings. Please stop polluting the issue queue.

    If you really want to contribute meaningfully, manual testing is great for an alpha release.

Production build 0.71.5 2024