- Issue created by @phenaproxima
- Assigned to kunal.sachdev
- Open on Drupal.org →Core: 10.1.x + Environment: PHP 8.1 & MySQL 8last update
over 1 year ago Not currently mergeable. - @kunalsachdev opened merge request.
- last update
over 1 year ago 758 pass - Issue was unassigned.
- Status changed to Needs review
over 1 year ago 6:59am 26 April 2023 - Assigned to yash.rode
- Issue was unassigned.
- Status changed to RTBC
over 1 year ago 10:09am 26 April 2023 - 🇮🇳India yash.rode pune
This looks good to me +1 on not adding any extra test.
- last update
over 1 year ago 758 pass -
phenaproxima →
committed 9b381244 on 3.0.x authored by
kunal.sachdev →
Issue #3356395 by kunal.sachdev: ComposerInspector::validateProject()...
-
phenaproxima →
committed 9b381244 on 3.0.x authored by
kunal.sachdev →
- Status changed to Fixed
over 1 year ago 11:26am 26 April 2023 - Status changed to Needs review
over 1 year ago 1:41pm 26 April 2023 - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
--no-ansi
definitely was a bug — I intended the opposite 🙈--no-interaction
: I disagree, it's not because it currently doesn't ever interact, that it won't in the future either. It's specifically listed in the output forcomposer help validate
, so I think we should keep it.--no-cache
: I disagree, same reasoning as above.
- 🇺🇸United States phenaproxima Massachusetts
It's specifically listed in the output for composer help validate, so I think we should keep it.
I could be wrong but I suspect this is actually a generic option inherited from Symfony Console.
--no-cache: I disagree, same reasoning as above.
I disagree with your disagreement :) I once again suspect this is a generic option that Composer adds to its command classes; I don't see how
composer validate
would ever have use for a cache. If it ever does, we can restore this flag when we need it, and thus have documented and explicit reasoning (as well as a comment) for why we restored it. - 🇺🇸United States phenaproxima Massachusetts
To further support my point here: the
validate
command has no usage of the word "cache": https://github.com/composer/composer/blob/main/src/Composer/Command/Vali... - 🇺🇸United States phenaproxima Massachusetts
Oh, and another reason why we shouldn't add
--no-interaction
right now: as I understand it, --no-interaction will suppress any interactive prompts in favor of the default values for those prompts.If
composer validate
becomes interactive in the future, we won't know the defaults for those prompts, which means that--no-interaction
might inadvertently send us down a wrong path. - Status changed to Fixed
over 1 year ago 2:41pm 26 April 2023 - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Automatically closed - issue fixed for 2 weeks with no activity.