- Issue created by @mark_fullmer
- Status changed to Needs review
over 1 year ago 11:08pm 24 April 2023 - Open in Jenkins β Open on Drupal.org βCore: 10.1.x + Environment: PHP 8.1 & MySQL 5.7 updated depslast update
over 1 year ago 1 pass - last update
over 1 year ago 54 pass - πΊπΈUnited States mark_fullmer Tucson
Two patches are attached, one for 2.0.x and one for 8.x-1.x.
The approach here is to provide an MVP, where the drush command simply uses the settings defaults and adds a GTM ID.
Subsequent work could be done to provide more parameters in the drush command.
- Status changed to Needs work
over 1 year ago 4:20pm 9 May 2023 - πΊπΈUnited States japerry KVUO
For 2.x at least, all validation is skipped, so this patch should at least ensure the same validation we use in the form applies to the command.
- Status changed to Needs review
about 1 year ago 5:01pm 20 October 2023 - last update
about 1 year ago 54 pass - πΊπΈUnited States mark_fullmer Tucson
this patch should at least ensure the same validation we use in the form applies to the command.
Good call. The attached patch adds validation using the existing pattern from
TagContainer::GOOGLE_TAG_MATCH
in the Drush command. - Status changed to RTBC
8 months ago 8:50pm 29 March 2024 - πΊπΈUnited States mmarler
I was able to successfully create containers with drush. Validation checks out as well. Moving to RTBC.