- When installing the "group" module in Drupal version 9+ with version 3.0.1, a lot of warnings may appear.
Comparing version 8.x with version 3.x of the module group, it appears that the class "GroupContent" has been removed from the latter. This means that all hooks in the "rocket_chat_group" module at "modules/contrib/rocket_chat/modules/rocket_chat_group/rocket_chat_group.module" have stopped working.
- I think, the file "modules/rocket_chat_group/src/Entity/RocketChatGroupEntity.php" should be deleted, as it lacks proper annotations (using /** instead of /* to declare them), and should have an owner, revision_id like the one in the "group" module at https://git.drupalcode.org/project/group/-/blob/3.0.1/src/Entity/Group.php.
- Running phpcs --standard=Drupal,DrupalPractice rocket_chat shows many errors, indicating that the "rocket_chat" module does not follow the Drupal conventions outlined at
Drupal convention →
.
For example, the file "modules/rocket_chat_group/src/RocketChat/moduleHelper.php" should be renamed to "ModuleHelper.php", or $Channel should be changed to "$channel".
A patch is being created to fix the error code by 98%, which should save time for the maintenance team.
Needs work
3.0
Code
- remove the use stdClass, Exception... as these are standard php classes
Needs work to fix all the errors.