Applying PHPCS fixes to picture module

Issue created by @vimal_nadar
Issue was unassigned.
Status changed to Needs review over 1 year ago3:49pm 21 April 2023
Open on Drupal.org →
Core: 7.x + Environment: PHP 5.3 & MySQL 5.5
last update over 1 year ago
Waiting for branch to pass
Comment over 1 year ago →
🇮🇳India vimal_nadar
Open in Jenkins → Open on Drupal.org →
Core: 7.x + Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
Build Successful
Status changed to Needs work 4 months ago12:46pm 16 August 2024

🇵🇭Philippines cleavinjosh

Hi @vimal_nadar,

I applied patch #2 at branch 7.x-2.13 and it was not applied.

➜  picture git:(7.x-2.13) curl https://www.drupal.org/files/issues/2023-04-21/phpcs_issue_fix-3355661-2.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 15093  100 15093    0     0  32846      0 --:--:-- --:--:-- --:--:-- 32882
patching file picture.module
Hunk #2 FAILED at 230.
Hunk #3 FAILED at 244.
Hunk #4 FAILED at 255.
Hunk #5 succeeded at 459 (offset 3 lines).
Hunk #6 succeeded at 492 (offset 3 lines).
Hunk #7 FAILED at 839.
Hunk #8 succeeded at 983 (offset -13 lines).
Hunk #9 succeeded at 1055 (offset -13 lines).
Hunk #10 FAILED at 1141.
Hunk #11 succeeded at 1164 (offset -16 lines).
Hunk #12 succeeded at 1187 (offset -16 lines).
Hunk #13 FAILED at 1264.
Hunk #14 succeeded at 1387 (offset -35 lines).
Hunk #15 succeeded at 1397 (offset -35 lines).
Hunk #16 succeeded at 1413 (offset -35 lines).
Hunk #17 succeeded at 1459 (offset -35 lines).
Hunk #18 FAILED at 1474.
Hunk #19 FAILED at 1489.
Hunk #20 FAILED at 1513.
Hunk #21 FAILED at 1569.
Hunk #22 succeeded at 1578 (offset -40 lines).
Hunk #23 succeeded at 1751 (offset -40 lines).
Hunk #24 FAILED at 1785.
Hunk #25 FAILED at 1834.
Hunk #26 succeeded at 1794 (offset -112 lines).
Hunk #27 FAILED at 1859.
Hunk #28 succeeded at 2023 (offset -183 lines).
13 out of 28 hunks FAILED -- saving rejects to file picture.module.rej
➜  picture git:(7.x-2.13) ✗

Same thing happened when I tried it to 7.x-2.x.

➜  picture git:(7.x-2.x) curl https://www.drupal.org/files/issues/2023-04-21/phpcs_issue_fix-3355661-2.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 15093  100 15093    0     0  56567      0 --:--:-- --:--:-- --:--:-- 56740
patching file picture.module
Hunk #5 succeeded at 459 (offset 3 lines).
Hunk #6 succeeded at 492 (offset 3 lines).
Hunk #7 succeeded at 839 (offset 3 lines).
Hunk #8 succeeded at 999 (offset 3 lines).
Hunk #9 succeeded at 1071 (offset 3 lines).
Hunk #10 succeeded at 1157 (offset 3 lines).
Hunk #11 FAILED at 1183.
Hunk #12 succeeded at 1206 (offset 3 lines).
Hunk #13 succeeded at 1283 (offset 3 lines).
Hunk #14 FAILED at 1425.
Hunk #15 succeeded at 1438 (offset 6 lines).
Hunk #16 succeeded at 1454 (offset 6 lines).
Hunk #17 succeeded at 1503 (offset 9 lines).
Hunk #18 succeeded at 1543 with fuzz 1 (offset 34 lines).
Hunk #19 FAILED at 1558.
Hunk #20 succeeded at 1570 (offset 22 lines).
Hunk #21 succeeded at 1626 with fuzz 1 (offset 22 lines).
Hunk #22 succeeded at 1651 (offset 33 lines).
Hunk #23 succeeded at 1824 (offset 33 lines).
Hunk #24 succeeded at 1858 (offset 33 lines).
Hunk #25 succeeded at 1907 (offset 33 lines).
Hunk #26 succeeded at 1939 (offset 33 lines).
Hunk #27 succeeded at 2004 (offset 33 lines).
Hunk #28 succeeded at 2239 (offset 33 lines).
3 out of 28 hunks FAILED -- saving rejects to file picture.module.rej
➜  picture git:(7.x-2.x) ✗

Thank you.

Applying PHPCS fixes to picture module

Comments & Activities