Allow Funds balance order/transaction without requiring address

Created on 20 April 2023, about 1 year ago
Updated 3 November 2023, 8 months ago

Problem/Motivation

I would like to allow my friends to pay with Fund balance plugin without having them to fill the address form at checkout. Pretty standard usecase, I don't understand why should the special "address" field be required. Thank you 🙏🏻

Steps to reproduce

Create a payment gateway at /admin/commerce/config/payment-gateways/add
Select Plugin = Funds balance (don't apply any condition)
Add to cart any product, go to /cart and click Checkout
Select any existing Wallet or Funds balance (create new wallet)
Address fields are required to Continue to review

Feature request
Status

Fixed

Version

2.1

Component

Code

Created by

🇮🇹Italy kopeboy Mainland

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @kopeboy
  • 🇮🇹Italy kopeboy Mainland

    I could have phrased the issue "Remove dependency with drupal/address module" but I wouldn't know where to start looking among these dependencies:

    1. - Commerce:commerce
    2. - Commerce:commerce_checkout
    3. - Commerce:commerce_order
    4. - Commerce:commerce_payment
    5. - Commerce:commerce_product
    6. - Commerce:commerce_store
  • 🇭🇷Croatia Aporie

    Hi,

    This issue has been fixed in the dev branch.

    If you're using Drupal 10 you can safely use the dev version of the module.

    If you're still on D9 you can edit the module manually (or create a patch): https://git.drupalcode.org/project/commerce_funds/-/commit/ae815c97d1e81...

    Right now, the dev branch is only compatible with D10 (and no more D9) so I won't create any release before October, probably (except security or blocker issue).

  • 🇮🇹Italy kopeboy Mainland

    I found (maybe relevant) references to address at lines:

    • 110-115 of /tests/src/Functional/FundsTransactionElementTest.php
    • 106-111 of /tests/src/Functional/DefaultFormsTest.php

    and at (maybe irrelevant) lines 161 and 171 of /src/Plugin/Funds/WithdrawalMethod/Check.php

    For the future maybe it will make sense to explicitate the dependency on (core) drupal:profile, since I see this module defines a "Funds payment" profile type (/config/install/profile.type.funds_payment.yml)

  • Status changed to Fixed 8 months ago
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.69.0 2024