- Issue created by @poker10
- Status changed to Needs review
over 1 year ago 8:19pm 19 April 2023 - last update
over 1 year ago 2,149 pass - last update
over 1 year ago 2,145 pass - last update
over 1 year ago 2,149 pass - last update
over 1 year ago 2,110 pass - last update
over 1 year ago run-tests.sh exception - last update
over 1 year ago 2,149 pass - last update
over 1 year ago 2,149 pass - last update
over 1 year ago 2,149 pass - last update
over 1 year ago 2,110 pass - last update
over 1 year ago 2,149 pass - last update
over 1 year ago 2,149 pass - Status changed to RTBC
over 1 year ago 9:15pm 19 April 2023 - 🇬🇧United Kingdom longwave UK
Good catch. This is the correct fix - replacing the
::class
constant with the string name of the class, which in D7 is just the class name as core does not use namespaces. - 🇺🇸United States dmundra Eugene, OR
Agreed and the patch worked for our site running on PHP 5.4 as well.
- 🇯🇲Jamaica axle_foley00
Confirming that I stumbled across this issue as well. Patch in #3 fixes this issue.
- 🇬🇧United Kingdom mcdruid 🇬🇧🇪🇺
Thanks for this.
+1 on making this change and doing a hotfix release for D7.
However, I think this highlights the fact that it's not viable for D7 to continue supporting really old PHP versions.
For what it's worth, the testing system that's used for private security issues is slightly different to how public issues are tested on d.o.
We should discuss this in a separate issue - I'll link to it from here.
- Status changed to Fixed
over 1 year ago 9:58am 21 April 2023 - 🇬🇧United Kingdom mcdruid 🇬🇧🇪🇺
Linked an older issue that's still open to discuss increasing the minimum required PHP version for D7 core.
Working on a hotfix release for D7 which will include this patch.
- 🇬🇧United Kingdom mcdruid 🇬🇧🇪🇺
- 🇳🇱Netherlands Jan-E
Silly thing:
drush pm-update
stumbles over ::class in system.module. The site was running under PHP 7.1, but drush was using PHP 5.4.41. Applying the patch manually fixed things. I really need to update php in drush (on a Windows server),
Automatically closed - issue fixed for 2 weeks with no activity.