Edge case: Illegal offset error in Drupal FormBuilder

Open on Drupal.org →

Created on 19 April 2023, about 1 year ago

Updated 19 May 2024, about 1 month ago

Problem/Motivation

Under some rare circumstances, the \Drupal\gin\GinContentFormHelper::formAlter may set the $form['gin_sidebar']['actions']['#type'] to an empty array which then can lead to an illegal offset exception in Drupal's \Drupal\Core\Form\FormBuilder::doBuildForm at line 1030 where it calls $this->elementInfo->getInfo($element[$key]['#type'])

Proposed resolution

The default value should not be set to an empty array but to the string actions.

🐛 Bug report

Status

Fixed

Version

3.0

Component

Code

Created by

🇩🇪Germany jurgenhaas Gottmadingen

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!246Edge case: Illegal offset error in Drupal FormBuilder
Merged
🇩🇪Germany jurgenhaas
updated about 2 months ago

Comments & Activities

Issue created by @jurgenhaas
Merge request !246Issue #3355054: Edge case: Illegal offset error in Drupal FormBuilder → (Merged) created by jurgenhaas
Status changed to Needs review about 1 year ago8:30am 19 April 2023
Comment about 1 year ago →
🇩🇪Germany jurgenhaas Gottmadingen
For further details, we have discovered this while working on an ECA bug fix in 🐛 eca_form: Ajax using limited validation errors leads to faulty reads of submission values Fixed and this Gin bug kicked in from comment #9 and below.
Status changed to RTBC about 2 months ago10:05pm 29 April 2024
Comment about 2 months ago →
🇺🇸United States Darren Oh Lakeland, Florida
This fix is working. To test, unset the #type property of an actions element.
Comment about 2 months ago →
🇨🇭Switzerland saschaeggi Zurich
saschaeggi → changed the visibility of the branch 3355054-edge-case-illegal to hidden.
Comment about 2 months ago →
🇨🇭Switzerland saschaeggi Zurich
saschaeggi → changed the visibility of the branch 3355054-edge-case-illegal to active.
Comment about 2 months ago →
System Message

saschaeggi → committed 2744c660 on 8.x-3.x authored by jurgenhaas →
Issue #3355054: Edge case: Illegal offset error in Drupal FormBuilder
Status changed to Fixed about 2 months ago10:40am 5 May 2024
Comment about 2 months ago →
🇨🇭Switzerland saschaeggi Zurich
Thanks, Jürgen 👍
Comment about 2 months ago →
🇨🇭Switzerland saschaeggi Zurich
Comment about 1 month ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024