Issue when linking to content with ampersands or single quotes in the title

Open on Drupal.org →

Created on 19 April 2023, almost 2 years ago

Updated 1 May 2023, almost 2 years ago

The suggestion label and descriptions are HTML-escaped in the matcher plugins. This becomes an issue when the values are then used in the user interface other than the LinkIt suggestion list. For example in #2712951: Linkit for Link field the label is injected into the Title for a Link field.

As a result, the URL Title displays escaped html entities:
Target node title -> "test'it" will pass back in json suggestions like "test'it" and then fill into the link text field as "test'it" which should be "test'it"

Instead of take out the "Html::escape" from buildLabel function of all matcher classes I decide to add in decode handler via js

🐛 Bug report

Status

Closed: duplicate

Version

6.0

Component

Code

Created by

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Comments & Activities

Issue created by @inoodle
Comment almost 2 years ago →
inoodle
Comment almost 2 years ago →
inoodle
I have attached a patch for linkit 6.0.0rc1 https://www.drupal.org/project/linkit/releases/6.1.0-rc1 →
Comment almost 2 years ago →
inoodle
Also a back porting patch to https://www.drupal.org/project/linkit/issues/2712951#comment-14956491 ✨ Linkit for Link field Fixed
Status changed to Needs review almost 2 years ago5:33am 21 April 2023
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
last update almost 2 years ago
Patch Failed to Apply
Comment almost 2 years ago →
🇳🇿New Zealand RoSk0 Wellington
I suppose that should be in the "Needs review" for #3.
Comment almost 2 years ago →
inoodle
back porting patch to https://www.drupal.org/project/linkit/issues/2712951#comment-14956491 ✨ Linkit for Link field Fixed with updated name
Comment almost 2 years ago →
inoodle
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.1 & MariaDB 10.3.22
last update almost 2 years ago
Patch Failed to Apply
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
last update almost 2 years ago
92 pass
Comment almost 2 years ago →
🇳🇿New Zealand ericgsmith
Appears to be a duplicate of https://www.drupal.org/project/linkit/issues/2981543 🐛 Issue when linking to content with ampersands or single quotes in the title Fixed

@inoodle suggest adding your patch + suggested approach there and closing this as a duplicate.
Status changed to Closed: duplicate almost 2 years ago11:46pm 1 May 2023
Comment almost 2 years ago →
🇳🇿New Zealand ericgsmith
@inoodle I've added your patch + a test to #2981543

I believe this should be closed as a duplicate issue

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024