Drupal 9 compatibilty

Created on 18 April 2023, over 1 year ago
Updated 8 June 2023, over 1 year ago

Problem/Motivation

I got an error report from a friend who was testing same page preview on a Drupal 9 site. Looks like we might have some issues there to fix.

Screenshot of issue:

Steps to reproduce

* Test with D9

Proposed resolution

Record any issues that are discovered.

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Closed: won't fix

Version

2.0

Component

Code

Created by

🇺🇸United States cosmicdreams Minneapolis/St. Paul

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @cosmicdreams
  • 🇺🇸United States cosmicdreams Minneapolis/St. Paul

    After looking at this a bit I think I see the following:

    * Same Page Preview benefits from the work that was done with the off-canvas dialog.
    * Specifically the all: reset that applies to the containing element
    * the css the node module's node.preview.css is exactly the same between drupal 9 and 10.1

    It looks like the issue we're seeing in Drupal 9 will require quite a bit of work to fix. Maybe we should just say same_page_preview requires Drupal 10 and above?

  • 🇺🇸United States cosmicdreams Minneapolis/St. Paul
  • @cosmicdreams opened merge request.
  • Status changed to RTBC over 1 year ago
  • 🇺🇸United States cosmicdreams Minneapolis/St. Paul

    So are we done here?

  • First commit to issue fork.
  • 🇮🇳India rajeshreeputra Pune

    Rebased MR and looks like dropping support for Drupal 9 and only support Drupal 10, am I, right?.

  • Status changed to Closed: won't fix over 1 year ago
  • 🇺🇸United States brianperry

    Appreciate the work here, but now that we have introduced Single File Components into 2.1.x I think that means that we won't be supporting Drupal 9 for this module. Marking as wontfix.

Production build 0.71.5 2024