Regression in Views argument plugins (date and all terms)

Hi there,

I seem to be having this issue as well. After (drupal 9) upgrading from search_api 1.28 to 1.29. I've reverted back to 1.28 until there is a patch. I may try and investigate.

Thanks

Here is a patch to fix it.

I'm not sure if there is a good way to fix the test so that it catches this issue. It is a Unit Test that mocks the SearchApiQuery object and the test is checking mock objects instead of getting the conditions from the actual query (where the conditions were not present).

https://git.drupalcode.org/project/search_api/-/blob/8.x-1.x/tests/src/U...

Thanks for reporting this issue and providing a patch. Also thanks to Mike for pinging me on Slack, spotting the cause and also that the date argument plugin is affected, too. This is indeed quite a bad regression. Even worse that our automated tests didn’t catch it.
However, your proposed solution doesn’t take the new API introduced in 📌 Add a $add_directly parameter to QueryInterface::createConditionGroup() Fixed into account, to which we should definitely still switch. Also, we should also fix the date plugin, while we’re at it.

Patch attached, please test/review!

Hi. Thanks, drunken monkey
Patch #4 saved my life

drunken monkey → credited miedward → .

Good to hear! I’ll take that as a confirmation that the patch worked as expected.
Committed. Thanks again, everyone!

Automatically closed - issue fixed for 2 weeks with no activity.

When can we expect a release for this fix?

@phma: Fix is included in 8.x-1.30 :)