- Issue created by @Eric_A
- 🇳🇱Netherlands Eric_A
Ok, things are not that simple.
There are two drush command files. One that is loaded by Drush 8 and older and one that is loaded by Drush 9 and higher.
These Drush versions have their own Drupal core version compatibility.
https://www.drush.org/latest/install/#drupal-compatibility - 🇳🇱Netherlands Eric_A
If you're on Drush 9 or Drush 10 it would appear that you must be running Drupal 8 or Drupal 9 and not 10. If you're on Drush 11 you could still be on Drupal 9.
So the command class must be compatible with Drupal 8 and 9.0, 9.1 and 9.2 if the info files claims that the module code is runnable on ^8 || ^9.
Old potx.drush.inc files are only loaded by Drush 8 or lower, so that file must be compatible with Drupal 8. Drush 9 is not compatible with Drupal 9 and higher so no point in trying to handle thoses versions. - 🇳🇱Netherlands watergate
I agree that the compatibility claim in the
potx.info.yml
is currently incorrect.If the 8.x-1.x version of this module should still support Drupal 8, and therefore Drush 8, then I would propose creating a 2.x version/branch for this module that supports Drupal core ^9.3 || 10 (and thereby Drush 10 and 11). The 8.x-1.x should be made compatible with Drupal 8 again (this means that the changes made in 📌 Drupal 10 compatibility fixes for potx Fixed should be partially rolled back).
If Drupal 8 support can be dropped in this module's 8.x-1.x version, the proposed commit tag would be a friendly gesture. To prevent confusion, the
potx.drush.inc
should be removed since only Drush 10 or higher should be supported. - 🇮🇳India Shreya_98
I have made changes in info.yml for incorrectly claims ^8 || ^9 || 10 core compatibility and fixed whatever mistake was there .Kindly review the patch file .
- 🇮🇳India Shreya_98
Ignore the previous patch file . Kindly review the updated patch file in that i have made changes in info.yml for incorrectly claims ^8 || ^9 || 10 core compatibility and fixed whatever mistake was there .
- Status changed to Needs work
over 1 year ago 10:21am 13 September 2023 - 🇮🇳India rushiraval
@Shreya_th for which version you have provided patch. I have reviewed patch manually. I think it is for .info file. which is for Drupal 7.