Fix coding standards

FILE: isbn/isbn.install -------------------------------------------------------------------------------------- FOUND 4 ERRORS AFFECTING 3 LINES -------------------------------------------------------------------------------------- 1 | ERROR | [x] Missing file doc comment 5 | ERROR | [x] Doc comment short description must be on the first line 5 | ERROR | [x] Function comment short description must start with exactly one space 7 | ERROR | [x] Additional blank lines found at end of doc comment -------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------- FILE: isbn/README.txt ---------------------------------------------------------------------- FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES ---------------------------------------------------------------------- 1 | WARNING | Line exceeds 80 characters; contains 136 characters 3 | WARNING | Line exceeds 80 characters; contains 111 characters 5 | WARNING | Line exceeds 80 characters; contains 264 characters 13 | WARNING | Line exceeds 80 characters; contains 181 characters ---------------------------------------------------------------------- FILE: isbn/src/Plugin/Field/FieldWidget/IsbnWidget.php ----------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ----------------------------------------------------------------------------------------------- 24 | ERROR | [x] Missing function doc comment 32 | ERROR | [x] Use null coalesce operator instead of ternary operator. ----------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------- FILE: isbn/src/Plugin/Field/FieldType/IsbnItem.php ------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------- 58 | ERROR | [x] Missing function doc comment ------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------- FILE: isbn/src/Plugin/Field/FieldFormatter/IsbnFormattedFormatter.php -------------------------------------------------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 3 LINES -------------------------------------------------------------------------------------------------------------- 49 | ERROR | [x] Missing function doc comment 52 | ERROR | [x] Expected 1 blank line after function; 0 found 53 | ERROR | [x] The closing brace for the class must have an empty line before it -------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------- FILE: isbn/src/Plugin/Field/FieldFormatter/IsbnPlainFormatter.php ---------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ---------------------------------------------------------------------------------------------------------- 47 | ERROR | [x] Expected 1 blank line after function; 0 found 48 | ERROR | [x] The closing brace for the class must have an empty line before it ---------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------- FILE: isbn/src/Plugin/Validation/Constraint/IsbnConstraint.php ------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------- 23 | ERROR | [x] The closing brace for the class must have an empty line before it ------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------- FILE: isbn/src/Plugin/Validation/Constraint/IsbnConstraintValidator.php ---------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ---------------------------------------------------------------------------------------------------------------- 8 | ERROR | [x] Missing class doc comment 10 | ERROR | [x] Missing function doc comment ---------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------- FILE: isbn/src/IsbnToolsService.php ---------------------------------------------------------------------------------------------- FOUND 12 ERRORS AFFECTING 11 LINES ---------------------------------------------------------------------------------------------- 3 | ERROR | [x] There must be one blank line after the namespace declaration 9 | ERROR | [x] Missing class doc comment 11 | ERROR | [ ] Class property $isbn_tools should use lowerCamel naming without underscores 11 | ERROR | [ ] Missing member variable doc comment 20 | ERROR | [x] Missing function doc comment 23 | ERROR | [x] Expected newline after closing brace 28 | ERROR | [x] Missing function doc comment 32 | ERROR | [x] Missing function doc comment 35 | ERROR | [x] Expected newline after closing brace 39 | ERROR | [x] Missing function doc comment 42 | ERROR | [x] Expected newline after closing brace 46 | ERROR | [x] Missing function doc comment ---------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 10 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------

Comments & Activities

Issue created by @megachriz
@megachriz opened merge request.
Issue was unassigned.
Status changed to Needs review over 1 year ago10:11am 18 April 2023
Comment over 1 year ago →
🇳🇱Netherlands megachriz
I also added:

Dependency injection;

An interface for the service "isbn.isbn_service".

It might be a good idea to commit 📌 Add test coverage Fixed first, so less to none manual testing for this ticket would be required.
Status changed to Needs work over 1 year ago3:34pm 18 April 2023
Comment over 1 year ago →
🇵🇭Philippines clarkssquared
Hi megachriz,

I applied your MR !4 in my local with Drupal 9.5.7 to the ISBN Field" module against Version 8.x-1.x-dev. and I noticed that there are still phpcs warnings/issues reported

Please see the screenshots attached.

For your review.
Thank you.
Status changed to Needs review over 1 year ago4:14pm 18 April 2023
Comment over 1 year ago →
🇳🇱Netherlands megachriz
@clarkssquared
Thanks for checking. This was on purpose. The README changes are already handled in 📌 Replace README.txt with README.md Fixed (I mentioned this briefly on the issue summary).
Status changed to RTBC over 1 year ago4:22pm 18 April 2023
Comment over 1 year ago →
🇵🇭Philippines clarkssquared
Hi MegaChriz,

Sorry, I did not notice it. Hence I will move this to RTBC

Thank you.
Comment over 1 year ago →
🇳🇱Netherlands megachriz
Thanks, though it would be good to test the module manually to ensure that no errors occur. I tested it on PHP 8.1 and didn't notice any errors so far.
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
last update over 1 year ago
12 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
12 pass
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
last update over 1 year ago
12 pass
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
last update over 1 year ago
12 pass
Comment over 1 year ago →
System Message

MegaChriz → committed d4f4acb6 on 8.x-1.x
Issue #3354854 by MegaChriz: Fixed coding standards.
Status changed to Fixed over 1 year ago7:55am 16 May 2023
Comment over 1 year ago →
🇳🇱Netherlands megachriz
Tests were passing on both D9 and D10. I merged the code!
Comment over 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comments & Activities