Contrib.social

The $_GET super global must not be accessed directly; inject the request_stack service and use $stack->getCurrentRequest()->query->get('code') instead

Open on Drupal.org →
Created on 18 April 2023, over 1 year ago
Updated 19 April 2023, over 1 year ago

Problem/Motivation

Upon running phpcs, there is an issue seen in CalbackController.php - 'The $_GET super global must not be accessed directly; inject the request_stack service and use $stack->getCurrentRequest()->query->get('code') instead'

Steps to reproduce

Run phpcs on the module.

Proposed resolution

Inject request_stack service and use it to access the GET variables.

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task
Status

Fixed

Version

1.0

Component

Code

Created by

🇮🇳India sidharth_soman Bangalore

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024