Add a security group select box to the OpenStack instance edit form

@xiaohua-guan

Thank you for the patch. I tested the patch and it looks working fine. I posted my comments for the refactorings. Thanks!

@xiaohua-guan

Thank you for the update. I was wrong about the logic. Can you please review my comments? Thanks

@xiaohua-guan

Thank you for the update. I posted my comment.

@xiaohua-guan

Thank you for the update. It looks good to me. I'll merge the patch to 4.x, 5.x and 6.x, and close this issue as Fixed.

@yas

I posted my hot fix. Please take a look again. Thanks.

@xiaohua-guan

Thank you for supplying the hotfix. Can you please put static w/ function in the closure? Also, please check and refactor the current merge commit to add static if necessary.

+      $new_security_groups = array_filter(array_map(static function ($value) use ($security_group_name_id_map) {
+        return $security_group_name_id_map[$value] ?? NULL;
+      }, array_keys($form_state->getValue('security_groups'))));

+      $old_security_groups = array_filter(array_map(static function ($value) use ($security_group_name_id_map) {
+        return $security_group_name_id_map[$value] ?? NULL;
+      }, $form['network']['security_groups']['#default_value']));

@yas

Thanks for your comment. I uploaded a new diff file. Please take a look again.

@xiaohua-guan

Thank you for the update. It looks good. I'll merge the patch to 4.x, 5.x and 6.x, and close this issue as Fixed.

Automatically closed - issue fixed for 2 weeks with no activity.