Not compatible with PHP 8.1

looking in git and it seems that the maintainer has already added 8.1 support to an unpublished 1.0-dev version. Might be good if he were to do a release with this (which i guess i could as well).

committed to 1.0.2

hmm.. perhaps this is why the maintainer had not committed this:

Fatal error: Uncaught TypeError: Drupal\entity_clone\Plugin\Derivative\DynamicLocalTasks::__construct(): Argument #2 ($string_translation) must be of type Drupal\Core\StringTranslation\TranslationManager, Drupal\tranc\TrancTranslationManager given, called in E:\www\SSC\myssc\html\modules\contrib\entity_clone\src\Plugin\Derivative\DynamicLocalTasks.php on line 49 and defined in E:\www\SSC\myssc\html\modules\contrib\entity_clone\src\Plugin\Derivative\DynamicLocalTasks.php on line 38

quiet note: you are a maintainer of the project :)

this small patch removes the issue with realpath; but not sure if this breaks something. wouldnt think it could.

this is against 1.0.1

you could alternatively just stringcast it

re: #6 - yes, oddly enough i seem to be.

anyway, my patch works for us as far as i know.. but will test more later. I suspect my merging your patch for this and releasing 1.0.2 was not a great idea and this makes latest release broken. I guess i can remove it but you never commented on this so will leave it for now.

Typehinting with a class is always wrong but since there is no single interface for the translation manager and union types only arrived in PHP8, well, here we are -- tranc itself does the same :/ I guess we could extend the core translation manager class for compatibility reasons which should be fine since we are overriding every method.

Patch for entity_clone that appears to solve the issue raised in #5.

Ok patch 11 didn't help,

Try patch 12

Patch 12 is incomplete, I've improved it in patch #14

Try this

What about this.

wow ya lots of gaffes in patch 14

this time try: 16

ok @chx, your patch is better, I will try that.

Patch 15 works and is the most reasonable solution, thank you so much @chx

Charlie ChX Negyesi → credited chx → .

Committed #15 and a string cast.

Great work! :) Happy US thanks giving. We had ours in Canada last month in October.

Our summers have longer days so maybe explains why we have thanks giving sooner. Where I'm sitting our longest day with sunrise to sunset is over 17 hours in June/July. Where I grew up about 300 miles further north the nautical day is 24 hours for a few weeks, meaning the sun may be set but there's still enough light to navigate for 24 hours per day without needing a flashlight or lights.

Automatically closed - issue fixed for 2 weeks with no activity.