- π¬π§United Kingdom james.williams
I should note that the pages that the view_mode_page module makes possible, don't get nicely named transactions with this change; but the point is that they are now distinguished as separate to the ordinary canonical node pages that this module does give the nice names for. Which is enough for me, though I can of course imagine it would be even nicer to give per-bundle names for the view_mode_page pages. But there aren't going to be many people actually needing that. Of course, if there's a need, further work on top of this patch is welcome! :-D
- π―π΅Japan ultrabob Japan
Thanks for taking the time to submit this patch James! We'll review it over the next few days.
- πΊπΈUnited States mikemccaffrey
Is there a reason that if it is a StackedRouteMatchInterface (which I am assuming is a sub-request) that it can't simple return out of the function, since the transaction has already be named by the parent transaction?
- π―π΅Japan ultrabob Japan
Actually looking into it a bit further, all currentRouteMatch are instances of StackedRouteMatchInterface. The patch is there because the event is fired multiple times in the case of a sub request, so I'll adjust this patch to return whenever the event is not firing on the master request.
- @ultrabob opened merge request.
- @ultrabob opened merge request.
- Issue was unassigned.
- Status changed to RTBC
over 1 year ago 9:48am 21 June 2023 - π¬π§United Kingdom james.williams
That looks to fix the situation I originally reported, and I'm fine with its effect on others I'm aware of. Thanks! The indentation of the change is a little off still, but otherwise I'm happy. Not sure whether I'm the right person to set this to RTBC, but if you're happy, I'm happy!
- First commit to issue fork.
-
RobLoach β
committed 459171a0 on 1.0.x authored by
ultrabob β
Issue #3354647 by ultrabob, james.williams, RobLoach: Name transactions...
-
RobLoach β
committed 459171a0 on 1.0.x authored by
ultrabob β
- Status changed to Fixed
over 1 year ago 5:49pm 22 June 2023 - π¨π¦Canada RobLoach Earth
Thanks James and Bob for pushing this forwards! Fixed up the whitespace, and merged. +1
Should be available in the next version.
Automatically closed - issue fixed for 2 weeks with no activity.