Contrib.social

Fix the issues reported by phpcs

Open on Drupal.org →
Created on 17 April 2023, almost 2 years ago
Updated 18 April 2023, almost 2 years ago

Problem/Motivation

FILE: C:\xampp\htdocs\backendassignment\web\modules\contrib\config_modify-3354601\src\ConfigInstaller.php
---------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
34 | ERROR | [ ] Missing @var tag in member variable comment
---------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------

FILE: C:\xampp\htdocs\backendassignment\web\modules\contrib\config_modify-3354601\src\ConfigModifyServiceProvider.php
---------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
---------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------

FILE: C:\xampp\htdocs\backendassignment\web\modules\contrib\config_modify-3354601\src\Updater.php
-------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
-------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------

FILE: ...dassignment\web\modules\contrib\config_modify-3354601\tests\modules\test_config_modify\test_config_modify.info.yml
------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
------------------------------------------------------------------------------------------------------------------------

FILE: ...b\modules\contrib\config_modify-3354601\tests\modules\test_config_modify_enable\test_config_modify_enable.info.yml
------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
------------------------------------------------------------------------------------------------------------------------

FILE: C:\xampp\htdocs\backendassignment\web\modules\contrib\config_modify-3354601\tests\src\Kernel\ModifyTest.php
-----------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
19 | ERROR | [ ] Missing @var tag in member variable comment
-----------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------

Time: 922ms; Memory: 6MB

Steps to reproduce

Run phpcs on the module.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task
Status

Closed: cannot reproduce

Version

1.0

Component

Code

Created by

🇮🇳India sidharth_soman Bangalore

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment almost 2 years ago →
    🇳🇱Netherlands kingdutch

    Thanks for being the first person who isn't me to open an issue in the issue queue for this module and claiming issue #2! 🎉

    It looks like you're running PHPCS from Windows where your IDE has probably automatically converted your linebreaks from \n to \n\r. You can see in your MR that no linebreaks are actually changing because my (and probably your) git is configured to automatically convert everything to \n, so the repository doesn't have this issue.

    It also looks like you're running an outdated version of coder. In newer versions the @var annotation may be omitted when using PHP types. I helped fix this in #3123282: Do not require @var tag if a property has typehint → :D

    The outdated coder version may also cause the false-positives for the version in info.yml files for test modules. This pattern is quite common in Drupal Core.

    When opening coding standards related issues, please be sure to look at and understand the results of running PHPCS. It's a tool to assist you, not one to be followed blindly :)

  • Comment almost 2 years ago →
    System Message
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024