- Issue created by @gangu
- 🇮🇳India gangu
When I update "shs module" in dev server Its not working.Attached screenshot for reference.
- 🇺🇸United States kreynen
@Aneida brought this up in 🌱 D10 Support Fixed
The issue is 'static' return type declaration is only allowed in versions of PHP ^8.0. The underlying problem is that support for PHP7 ends in November and anyone working in D10 is already working in ^8.1.
I see 3 potential options
- Rollback the D10 changes in the 2.0.x branch, create a 3.0.x branch and make the changes necessary for D10/PHP8.1 compatibility there
- Add the minimum php requirement to the composer.json (@Aneida suggestion). I believe this results in Composer keeping the rc3 releases for projects where the PHP version is set to 7 in the root composer.json, but the module would still be flagged as needing an update by Update Status since on the rc4 release is supported
- Rewrite the static declaration so it works with both D9/PHP7 and D10/PHP8
- @kreynen opened merge request.
- Status changed to Needs review
over 1 year ago 4:04pm 19 April 2023 - 🇺🇸United States kreynen
I made a MR that adds https://git.drupalcode.org/issue/shs-3354549/-/compare/2.0.x...3354549-d...
I think this would prevent composer from including a new rc5 release in builds that require PHP 7, but I think composer would still include rc4 because it doesn't have a PHP version requirement. I can't really test this without the PHP requirements being committed to a release. I tried looking at the metadata packages.drupal.org is returning about releases by following https://drupal.stackexchange.com/questions/259157/how-to-get-projects-da..., but I can't get to the project details using the pattern returned in https://packages.drupal.org/8/packages.json
When I try to access the project using drupal\/provider-2023-1$%hash%.json replacing the %hash% with d2b5f2c655ff47e88aeab86f02a3325319b9337ab824d5d6147a5b1709fa5e16, I get redirected to drupal.org. I was hoping I could see that Composer is seeing when it comes to projects that include a PHP requirement like https://git.drupalcode.org/project/metatag/-/blob/2.0.x/composer.json#L27.
I'm really not sure that adding a composer.json to a new release in the 2.0.x branch is going to fix this.
- 🇹🇭Thailand Nick Hope
This also affected me. I am on PHP7.4.23 and D9.5. rc4 made my SHS fields disappear. I rolled back to rc3 and re-applied the patch in this comment 🐛 Error saving null/empty value after 2.0.0-rc1 update Fixed . Not sure what the right approach is to resolving this but happy to test something.
- 🇦🇺Australia thomwilhelm Sydney
"The underlying problem is that support for PHP7 ends in November"
Hasn't PHP 7 been end of life since November 2022? I wouldn't expect contrib to actively fix modules based on a version that's EOL.
- 🇺🇸United States kreynen
@ThomWilhelm Sorry, yes. All versions of PHP7 are already EoL as far as PHP. It's 8.0 that ends in November 2023. It's hard keeping up with the pace of life off the island. I'm mainly focused on D10 compatibility right now.
- 🇺🇸United States DamienMcKenna NH, USA
If a minor code change would make the module compatible with D9 sites, I think it'd be worth doing?
- 🇮🇳India vpsaravanan
When updated to rc1 version from 8.x-1.0-alpha5, simple hierarchical select select box is not working. Taxonomy entity reference field is displaying as textbox instead of select box. This issue occurs in all rc version (2.0.0 (rc1, rc2, rc3 & rc4). I have installed php 7.4.33. I have attached screenshot for your reference
- 🇩🇪Germany zcht
This patch should fix the problem: #3357151 🐛 Use core/internal.backbone lib Needs work
- 🇹🇭Thailand Nick Hope
@zcht The patch at https://www.drupal.org/project/shs/issues/3357151 🐛 Use core/internal.backbone lib Needs work does not fix the problem. My SHS fields do still not appear with rc4 and that patch (with PHP7.4.23 and D9.5).