Consolidate UpdateErrorTest

After discussion with @kunal.sachdev, I'm gonna take this on to try and clarify it. It's very complicated, touchy stuff.

🏓

This was tricky to review, and in doing so, I think I found a now misnamed test method, one piece of now superfluous test logic and one missing assertion.

Assigning to @phenaproxima to confirm.

Back to you, Wim.

This looks far better now, and with excellent clarifications from @phenaproxima that really get to the heart of the problem: what UX the user is forced to go through depending on:

1. what happens (validation error vs exception/failure)
2. and when that happens (during which part of the stage life cycle)

👍

🚢

Oh, and per https://git.drupalcode.org/project/automatic_updates/-/merge_requests/84..., @phenaproxima, you are saying that the current test coverage proves that 📌 If an error occurs during an attended process, delete the stage on behalf of the user Needs review is unnecessary because it already works that way, right?

That issue is still necessary, because it doesn't delete the stage automatically in every circumstance.

PostCreateEvent errors will not destroy the stage; the other first-phase events will. I don't think a failure in any of the second-phase events will destroy it. That issue exists to decide if and how to make the behavior consistent.

Then I'm confused why we removed the @todo 😇 But no big deal — we still have the issue. 👍

We didn't.

The todo is still there, just a bit higher. (It was already there in two places.) We removed the irrelevant reference to it, but kept the relevant one.

#18 Oh, I must've missed that then!

Automatically closed - issue fixed for 2 weeks with no activity.