[random test failure] MenuUiTest::testMenuAdministration can generate "escaped locator"

This seems very similar to #3041318: Various random fails due to mis-triggered Mink deprecation error → , should we combine this issue in to that one?

I don't think we're gonna catch this in the repeating test job. Should have snuck it in to #3041318: [random test failure] Various fails when a random string is used in an xpath selector → but too late now. MR with the fix is up.

It did fail 1/500 times with a deprecation message

Passing an escaped locator to the named selector is deprecated as of 1.7 and will be removed in 2.0. Pass the raw value instead.

It's a shame we don't get a proper backtrace in the test output as there's no way I can see which line is triggering it.

The fixes do follow what we'd expect given the issue description though.

You're right, it did, see https://git.drupalcode.org/issue/drupal-3354138/-/jobs/4978417/viewer

I suppose we could run it a few more times to see if it's consistently in that realm, but it's pretty slow (48 mins for 500 runs). Then we'd need to run the fix that many times as well.

catch → closed merge request !11843

1/500 is enough to prove it fails, and we know from the other issue why and that using machine name will 'fix' it, let's switch to machine name.

I just now realised - what if we were to tag all these tests with @group legacy with a @todo to un-legacy them when mink 2.0 comes out, but we don't know when that would be, and we'd miss any other deprecations that are non-bogus in the meantime. We don't lose much by using machine name here so let's go ahead.

Committed/pushed to 11.x, thanks!

mstrelan → closed merge request !11841