- Issue created by @nagy.balint
- Assigned to scott_earnest
- Status changed to Closed: won't fix
over 1 year ago 10:33pm 9 June 2023 - πΊπΈUnited States scott_earnest
Hello @nagy.balint-
This module is geared specifically for oembed videos. I'm not sure I fully understand the question, but this module is dependent on the micromodal.js library. Perhaps you could leverage that for images? Please let me know if this is helpful or needs further discussion.
- ππΊHungary nagy.balint
The module loads the js library as
js: https://unpkg.com/micromodal@0.4.10/dist/micromodal.min.js: { type: external, minified: true }
in media_video_micromodal.libraries.yml
This means that it simply pulls the lib from external source.
This also means that if I would like to make a contrib module that also works with this micromodal, but for image media,
then I also need to implement a libraries yml and pull the library as an external source.In case I use both modules, then it will potentially pull it in twice, but at least when the version changes in one of the modules, will certainly pull it in twice.
The solution could be to have a micromodal contrib module which the other modules depend on, then we can avoid that problem.
Or to have a solution where we can include the library through composer, with for example the merge plugin. But in the current situation even if the other module used composer, this module would still pull the library in as an external.