Contrib.social

Coding Standard

Open on Drupal.org →
Created on 13 April 2023, over 1 year ago

Problem/Motivation

FILE: /var/www/TS_DRUPAL/modules/contrib/scheduler_content_moderation_integration/tests/src/Kernel/HookImplementationTest.php
--------------------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------------------------------------------------------------
 65 | ERROR | The array declaration extends to column 101 (the limit is 80). The array content should be split up over multiple lines
 70 | ERROR | The array declaration extends to column 103 (the limit is 80). The array content should be split up over multiple lines
 76 | ERROR | The array declaration extends to column 106 (the limit is 80). The array content should be split up over multiple lines
--------------------------------------------------------------------------------------------------------------------------------------
📌 Task
Status

Closed: won't fix

Version

1.0

Component

Code

Created by

🇮🇳India Neha Wadhwani

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @Neha Wadhwani
  • Issue was unassigned.
  • Status changed to Needs review over 1 year ago
  • Comment over 1 year ago →
    🇮🇳India Neha Wadhwani
  • Comment over 1 year ago →
    🇬🇧United Kingdom jonathan1055

    Hi Neha Wadhwani
    Please look at the actual test results run here on drupal.org https://www.drupal.org/pift-ci-job/2641255 →
    You will see that these array errors are not shown. That's because we have custom settings for a few of the coding standard sniffs. You need to run phpcs in the proper way, then those settings will be picked up and used. Either navigate into the project root folder and run phpcs .. Or from further up the folder hierarchy you need to specify the --standard parameter phpcs path/to/modules/scheduler_content_moderation_integration --standard=path/to/modules/scheduler_content_moderation_integration/phpcs.xml.dist

    Sorry, you have wasted your time making your patch.

  • Status changed to Closed: won't fix over 1 year ago
  • Comment over 1 year ago →
    🇺🇸United States smustgrave

    Closing as won't fix as this falls into the category of credit farming. And I avoid giving credit to such issues. If you wish to get involved in this project please pick an issue from the queue and work on that. We are also here to help with that.

    Thanks.

  • Comment over 1 year ago →
    🇬🇧United Kingdom jonathan1055

    I have also unticked the 'credit' checkbox below.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024