Core Group Block: Missing "wp-block-group__inner-container" in block editor after updating from 8.x-2.2 to Gutenberg 8.x-2.7

Created on 12 April 2023, about 1 year ago
Updated 11 June 2024, 12 days ago

Core Group Block: Missing "wp-block-group__inner-container" in block editor after updating from 8.x-2.2 to Gutenberg 8.x-2.7

🐛 Bug report
Status

Fixed

Version

2.7

Component

Code

Created by

🇮🇳India rkelkar

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @rkelkar
  • Pipeline finished with Skipped
    6 months ago
    #66528
  • Pipeline finished with Skipped
    6 months ago
    #68709
  • This is also happening to me - any updates? I tried updating to 8.x-2.8 and it's still happening there too. Nodes that had the "wp-block-group__inner-container" have it stripped out if I do as much as save the node without even having made any changes.

  • 🇧🇷Brazil isa.bel Balneário Camboriú

    isa.bel made their first commit to this issue’s fork.

  • Merge request !89Recreate group inner container → (Merged) created by isa.bel
  • 🇧🇷Brazil isa.bel Balneário Camboriú

    Based on the issue opened on Gutenberg repository: https://github.com/WordPress/gutenberg/issues/41124

    And solution provided here: https://github.com/WordPress/wordpress-develop/blob/6.0/src/wp-includes/...

    I have created an MR to add the changes necessary to recreate the group inner container. Which fixed the issue for me.

  • Pipeline finished with Failed
    5 months ago
    Total: 776059s
    #75139
  • Pipeline finished with Success
    5 months ago
    Total: 298s
    #83018
  • Pipeline finished with Success
    5 months ago
    Total: 195s
    #83131
  • Pipeline finished with Skipped
    5 months ago
    #83287
  • Pipeline finished with Failed
    5 months ago
    Total: 201s
    #90541
  • 🇧🇷Brazil isa.bel Balneário Camboriú

    Thank you for your suggestion @codebymikey, I added a protected method specific for this, refactored the code to be more comprehensive, and also added this part to the code, without the JSON check, as it's not needed in this case, and what is also suggested in the WP git issue here.

  • Pipeline finished with Failed
    5 months ago
    Total: 228s
    #90965
  • Pipeline finished with Skipped
    4 months ago
    #97566
  • Pipeline finished with Success
    4 months ago
    Total: 221s
    #108673
  • Pipeline finished with Failed
    4 months ago
    Total: 521s
    #111237
  • Pipeline finished with Success
    4 months ago
    Total: 735s
    #111241
  • Pipeline finished with Success
    4 months ago
    Total: 768s
    #111280
  • Pipeline finished with Failed
    3 months ago
    Total: 506s
    #127224
  • Pipeline finished with Success
    3 months ago
    Total: 185s
    #133209
  • Pipeline finished with Skipped
    2 months ago
    #153559
  • Pipeline finished with Success
    2 months ago
    Total: 186s
    #155707
  • Pipeline finished with Success
    2 months ago
    Total: 165s
    #155711
  • Pipeline finished with Success
    2 months ago
    Total: 163s
    #155716
  • Pipeline finished with Skipped
    about 2 months ago
    #155833
  • Pipeline finished with Success
    about 2 months ago
    Total: 235s
    #168080
  • Pipeline finished with Success
    about 2 months ago
    Total: 313s
    #168622
  • Pipeline finished with Success
    about 2 months ago
    Total: 271s
    #168628
  • Pipeline finished with Success
    about 2 months ago
    #168639
  • Pipeline finished with Canceled
    about 2 months ago
    Total: 241s
    #168649
  • Pipeline finished with Success
    about 2 months ago
    Total: 313s
    #168655
  • Pipeline finished with Success
    about 2 months ago
    Total: 285s
    #168669
  • Pipeline finished with Success
    about 1 month ago
    Total: 255s
    #171571
  • Pipeline finished with Success
    about 1 month ago
    Total: 170s
    #171783
  • First commit to issue fork.
  • Pipeline finished with Success
    about 1 month ago
    Total: 261s
    #176586
  • Pipeline finished with Success
    about 1 month ago
    Total: 277s
    #176592
  • Status changed to Fixed about 1 month ago
  • Status changed to Needs work about 1 month ago
  • I believe the $block variable/argument is missing, which means certain functionality wouldn't work as expected.

    https://git.drupalcode.org/project/gutenberg/-/merge_requests/129/diffs#...

    +    $is_not_default = isset($block['attrs']['layout']['type']) && $block['attrs']['layout']['type'] !== 'default';
    +    if ($is_inner_container || $is_not_default) {
    +      return $block_content;
    +    }
    

    And will need to reapplied to 3.x as well

  • Pipeline finished with Success
    about 1 month ago
    #177163
  • Pipeline finished with Success
    about 1 month ago
    Total: 254s
    #177377
  • Pipeline finished with Success
    about 1 month ago
    Total: 250s
    #177386
  • Pipeline finished with Canceled
    about 1 month ago
    Total: 10s
    #177920
  • Pipeline finished with Success
    about 1 month ago
    Total: 265s
    #177921
  • Pipeline finished with Success
    about 1 month ago
    Total: 323s
    #177930
  • Status changed to Needs review about 1 month ago
  • Status changed to Fixed 29 days ago
  • Pipeline finished with Success
    19 days ago
    #191001
  • Pipeline finished with Skipped
    16 days ago
    #193916
  • Pipeline finished with Success
    13 days ago
    Total: 221s
    #195928
  • Automatically closed - issue fixed for 2 weeks with no activity.

  • Pipeline finished with Success
    9 days ago
    Total: 240s
    #199088
  • Pipeline finished with Success
    9 days ago
    Total: 406s
    #199090
Production build 0.69.0 2024