- Issue created by @ruslan piskarov
- @ruslan-piskarov opened merge request.
- πΊπΈUnited States mark_fullmer Tucson
This looks like a duplicate of π Linkit Link field: File entities not processed like other entities, resulting in double-encoding Fixed ?
- @ruslan-piskarov opened merge request.
- Status changed to Needs review
over 2 years ago 2:23pm 11 April 2023 - πΊπ¦Ukraine ruslan piskarov Kyiv, Ukraine
Hi @mark_fullmer.
Price is a new issue, which appeared after π Linkit Link field: File entities not processed like other entities, resulting in double-encoding Fixed . - Assigned to mark_fullmer
- πΊπΈUnited States mark_fullmer Tucson
Thanks for clarifying, Ruslan. Based on the code change you're suggesting , it does indeed seem like only the filename would be rendered, rather than the relative path, since it's currently just
$entity->getFilename();
.I'd like to add test coverage for this, since it wasn't caught previously. That may or may not be a follow-up task, depending on time.
Assigning to myself for review...
- Status changed to Active
over 2 years ago 10:16pm 11 April 2023 - πΊπΈUnited States mark_fullmer Tucson
I've updated the issue description and title to better reflect the goal here. I'm also going to reclassify this as a "Feature request" rather than a "Bug," since display the plain filename without the filepath was the intent in the previous code change.
I'd like to hear from more users that they would prefer to see the filepath in the context of the Link widget. In the meantime, folks who want this can use the patch provided. Thanks for posting it!
- πΊπ¦Ukraine ruslan piskarov Kyiv, Ukraine
Hi @mark_fullmer,
This is most likely a bug, not a new feature request.
When we add a link to a file in link field, and save the node, everything works fine, node will be saved.
However if we edit the node again, Drupal shows an error because it should be the path, not the filename.
I prepared the short video for you https://take.ms/0gVVg. -
mark_fullmer β
committed 590e07c2 on 6.0.x authored by
Ruslan Piskarov β
Issue #3353476 by Ruslan Piskarov: Linkit for Link field: Files...
-
mark_fullmer β
committed 590e07c2 on 6.0.x authored by
Ruslan Piskarov β
-
mark_fullmer β
committed 26de83be on 6.1.x authored by
Ruslan Piskarov β
Issue #3353476 by Ruslan Piskarov: Linkit for Link field: Files...
-
mark_fullmer β
committed 26de83be on 6.1.x authored by
Ruslan Piskarov β
- πΊπΈUnited States mark_fullmer Tucson
I see your point, Ruslan! I hadn't tried to re-save the field after the modification was made to show just the filename. I've set this back to "Bug," tested the patch, and committed to both the 6.0.x and 6.1.x branches.
Thank you!
- Status changed to Fixed
about 2 years ago 3:59pm 30 April 2023 Automatically closed - issue fixed for 2 weeks with no activity.