- Issue created by @nubeli
- 🇺🇸United States colemanw
If no one has complained of fatal errors by this point... is that code even reachable?
Completely unused code should probably be removed rather than updated IMO. - First commit to issue fork.
- Status changed to Needs review
over 1 year ago 6:12am 9 April 2023 - 🇮🇳India Ranjit1032002
Created a patch for the issue mentioned, please review.
Thank You. - 🇨🇦Canada nubeli
@Ranjit1032002 there are a few problems with the patch:
-
WebformCivicrmPostProcess::adjustPageBreak()
doesn't exist.
-WebformCivicrmPostProcess::checkBillingPagination()
doesn't exist.
- Replacingdrupal_set_title()
with just$this->t('...)
doesn't do anything. You need to assign it to something and figure out a way to alter the title.
-webform_submission_access()
doesn't exist.
-WebformCivicrmPostProcess::preprocessComponentsForm()
doesn't exist.Please put in a bit more thought into the PR before submitting it.
The only thing that potentially works in this PR is putting in
\Drupal::service('civicrm')->initialize();
.After fixing things, I suggest testing out the PR first before posting it for others to review or test.
- 🇮🇳India jitendrapurohit
I dont see civicrm_initialize() anywhere in webform_civicrm.module.
@Ranjit1032002 Are you using the latest version?
I've raised a PR to fix this - https://github.com/colemanw/webform_civicrm/pull/870
- Status changed to Closed: outdated
over 1 year ago 8:25pm 16 April 2023