Incorporate improvements and join forces with entity_type_permissions

Created on 6 April 2023, over 1 year ago
Updated 11 April 2023, over 1 year ago

Problem/Motivation

Thank you very much for this great module. I just found this besides https://www.drupal.org/project/entity_type_permissions β†’ and think this might be the more stable one.

Still entity_type_permissions brought in some useful ideas, especially for UX. Wouldn't it make sense to join forces on this project, instead of having two separate projects, which are quite similar?

This makes the choice for users harder and most maintainer work is done twice...

So I'm asking. Thank you!

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

✨ Feature request
Status

Closed: won't fix

Version

1.1

Component

Code

Created by

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @Anybody
  • πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

    After testing out this module a bit, I can clearly say that the following points would be super helpful to also have in here:

    • You can (and should, after installation) configure permission scopes for different types of entities using settings. Now the permissions page looks simpler.
    • You can easily clear unnecessary permissions via module settings. You don't need to use the "reverse permissions" model to remove all the unnecessary permissions, as in the original module.
    • Permissions sorted by base entity type (Content, Comment, Media) first, and then by entity type (article, etc).

    On the other points:

    • PHP 7 support

      isn't that relevant anymore

    • Permissions model differs from original module. For example, users will only need to "View published content" to be able to view content, but also have "Access content items "Basic page"" to use operations.

      - should be discussed if helpful or not. But also not a bad idea!

  • Status changed to Closed: won't fix over 1 year ago
  • πŸ‡ΊπŸ‡ΈUnited States clayfreeman Paragould, AR

    It seems that the project to which you refer in the issue description forked this project:

    This simple module forked from Entity Bundle Permissions β†’ but much more useful.

    I'm not sure why the author of this downstream module decided to fork this project, but if you think these projects should be merged, then I would encourage you to open an issue on the downstream project to inquire about why a fork was necessary since that was not my decision.

    This project will not add support for PHP 7 or Drupal 8, since both are EOL. My company will not spend time to support EOL software. If the primary feature request is to suppress excess permission checks and generation, you will need to adjust the scope of this issue or open a separate issue for our consideration.

  • πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

    Thanks @clayfreeman!

    As written above, I just found both projects, no idea why it was forked, but there were some good ideas that should instead have gone into this project.

    This project will not add support for PHP 7 or Drupal 8, since both are EOL. My company will not spend time to support EOL software.

    As written above:

    PHP7 isn't that relevant anymore

    so wasn't part of my question.

    Thanks! :)

Production build 0.71.5 2024