Deprecated function errors in PHP 8.1

Open on Drupal.org →

Created on 6 April 2023, almost 2 years ago

Updated 10 April 2023, almost 2 years ago

Problem/Motivation

Use phpstan tool was found deprecated function notice occurs in PHP 8.1
------ ----------------------------------------------------------------------------------------------------------------------------------------------
Line /tmgmt/translators/file/tmgmt_file.recursive_iterator.inc
------ ----------------------------------------------------------------------------------------------------------------------------------------------
42 Return type mixed of method RecursiveDOMIterator::current() is not covariant with tentative return type mixed of method Iterator::current().
52 Return type mixed of method RecursiveDOMIterator::getChildren() is not covariant with tentative return type RecursiveIterator|null of method RecursiveIterator::getChildren().
62 Return type mixed of method RecursiveDOMIterator::hasChildren() is not covariant with tentative return type bool of method
RecursiveIterator::hasChildren().
72 Return type mixed of method RecursiveDOMIterator::key() is not covariant with tentative return type mixed of method Iterator::key().
79 Return type mixed of method RecursiveDOMIterator::next() is not covariant with tentative return type void of method Iterator::next().
86 Return type mixed of method RecursiveDOMIterator::rewind() is not covariant with tentative return type void of method Iterator::rewind().
96 Return type mixed of method RecursiveDOMIterator::valid() is not covariant with tentative return type bool of method Iterator::valid().
------ ----------------------------------------------------------------------------------------------------------------------------------------------

Proposed resolution

Update the function type of return value.

🐛 Bug report

Status

Needs work

Component

Core

Created by

🇺🇦Ukraine Igumnov_aleksey

Live updates comments and jobs are added and updated live.

PHP 8.1
The issue particularly affects sites running on PHP version 8.1.0 or later.

Sign in to follow issues

Comments & Activities

Issue created by @Igumnov_aleksey
Comment almost 2 years ago →
🇺🇦Ukraine Igumnov_aleksey
Comment almost 2 years ago →
🇺🇦Ukraine Igumnov_aleksey
According to documentation:
https://php.net/manual/en/recursiveiteratoriterator.valid.php
https://php.net/manual/en/recursiveiteratoriterator.rewind.php
https://php.net/manual/en/recursiveiteratoriterator.key.php
https://php.net/manual/en/recursiveiteratoriterator.next.php
https://php.net/manual/en/recursiveiteratoriterator.current.php
https://php.net/manual/en/recursiveiterator.haschildren.php
https://php.net/manual/en/recursiveiterator.getchildren.php
Status changed to Needs review almost 2 years ago8:31am 7 April 2023
Comment almost 2 years ago →
🇺🇦Ukraine Igumnov_aleksey
Status changed to Needs work almost 2 years ago8:56am 7 April 2023
Comment almost 2 years ago →
🇨🇭Switzerland berdir Switzerland
While the configured php version is very old, this will break compatibility with older php versions. We should add the annotation like I did in 📌 Fix D10.1 test fails Fixed for 8.x-1.x instaed.
Comment almost 2 years ago →
🇺🇦Ukraine Igumnov_aleksey
This decision is made from the fact that if Drupal 7 will work on php8.1

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024