- Issue created by @coaston
- ๐บ๐พUruguay jjose.quevedo
jjose.quevedo โ made their first commit to this issueโs fork.
- @jjosequevedo opened merge request.
- ๐บ๐พUruguay jjose.quevedo
Hi, I've added the seven theme as a required package in the composer.json file, as it is now a contrib theme
- Status changed to Needs work
over 1 year ago 3:44pm 16 June 2023 - ๐บ๐ธUnited States generalredneck
This is going to have to be a mandatory change. We aren't going to be able to rely on the magic that packages.drupal.org/8 does on the package.json to get this dependency in there. Normally, by listing a theme in base theme or dependencies properties get pulled by default. this was done here: https://git.drupalcode.org/project/thunder_admin/-/blob/8.x-3.x/thunder_...
However for the case of seven and a few others, this isn't automatically happening at the packagist level. You can see that here: https://packages.drupal.org/files/packages/8/p2/drupal/thunder_admin.json.
So this change will be required.
The problem is that this is only true for > drupal/core 10.0.0-alpha6... and having drupal/seven: ^1.0 combined with the dependency of drupal/core: ^9.2 || ^10 can't work... so you will have to change that too... otherwise people are going to get fatals from there being 2 themes installed with the name of seven when they upgrade to this version of the theme prior to upgrading to drupal 10.