Simplify Keycloak Authorize Method Using parent:authorize

Created on 5 April 2023, over 1 year ago
Updated 10 April 2023, over 1 year ago

Problem/Motivation

I've been working on a fork of keycloak to work through the issues in using it with openid_connect 3.0.0-alpha2. In doing that I had modified the Plugin/OpenIdConnectClient's authorize method to use the authorize method from the parent class. I've been trying to follow the recent updates in the beta5-beta11 changes and think the attached patch should maintain the beta11 functionality, while reducing the amount of code in the method. I don't know if there are other reasons to not call parent:authorize, but thought I'd share the code.

Checking further - I think this depends on the resolution of https://www.drupal.org/project/openid_connect/issues/3342661 ✨ Enable plugins to override the url_options in authorize method Closed: duplicate . I've applied the openid_connect.url_options_alter.3342661-2.patch locally.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

✨ Feature request
Status

Needs review

Version

2.2

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States qqmyers

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024