Created on 5 April 2023, about 1 year ago
Updated 13 October 2023, 9 months ago

Problem/Motivation

Follow up for #3316920: Remove aria-multiselectable from Accordions โ†’ . I have some sites using USWDS 3.x and 2.x. For the 2.x sites, that patch actually breaks accordions as this update from aria to data attributes happened in USWDS 3.x. That being said, 2.3.2 of this module is the last release that works with USWDS 2 out of the box, but does not have complete D10 compatibility.

I did some testing, and so far it seems that 2.4.3 works for both USWDS 2 and 3, aside from this one commit. This module makes no distinction as to which version of USWDS it supports, which I guess was fine until we started committing breaking changes :) I am working around this by just overriding the accordion template file in my custom theme, and using the pre-patched version.

I would propose we make this crystal clear for users. An easy way to do this would be to create a new branch, 3.x and simply tag the latest 2.4.3 as 3.0.0. Then revert #3316920: Remove aria-multiselectable from Accordions โ†’ and tag that as 2.4.4. In the release notes short description, we can advertise which USWDS version it supports, instructing USWDS 3 users to the latest major version.

Later on, we can drop support for USWDS 2, once users have migrated to 3.0.x. As of now, there doesn't seem to be any guidance as to when it will reach EOL. Perhaps we set our own timeline as to when we will stop backporting issues.

That is just my suggestion, but my point stands either way, as USWDS 3 continues to evolve, there can and will most likely will be more breaking changes what we will want to account for, and right now, there is no way to handle that on the Drupal side.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

๐Ÿ“Œ Task
Status

Fixed

Version

2.4

Component

Miscellaneous

Created by

๐Ÿ‡บ๐Ÿ‡ธUnited States devkinetic

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.69.0 2024