Clarify "Access By Reference" permission description

First code snippet to make this a bit clearer is the following behavior:

function access_by_ref_node_access(NodeInterface $node, $op, AccountInterface $account) {

    // Perform basic access checks
    if(
        !isset($account) || $op == 'create' || $account->id() == 0 || !isset($node) || !$account->hasPermission('access node by reference')
    ) {
        return AccessResult::neutral();
    }

So as it seems, if the permission "access node by reference" is not set, the module always returns AccessResult::neutral();!

Here's my suggestion:

Permission name: "Apply Access by Reference"
Description: "Applies the access by reference rules for the selected roles. If unchecked, the permissions will not be affected in any way (neutral)"

This should clarify things.

I'd even vote to rename the technical name "access node by reference" to something like "check node access by reference", but that's more complicated and should be discussed first.

Implemented #3 as MR!

Thanks, this makes it clearer for those that did not read this in the readme ;-)

In each case, the rule only applies to logged-in users with general permission
to access nodes by reference, and only on the node types and field names set in
the configuration page.

Merged in 3.x.x dev

Automatically closed - issue fixed for 2 weeks with no activity.