- Issue created by @tedbow
- @tedbow opened merge request.
- 🇺🇸United States tedbow Ithaca, NY, USA
I think to test this we need to update
\Drupal\Tests\package_manager\Kernel\ComposerInspectorTest::testMetapackagePath
and in the anonymous class we have instead the property$packagePath
being the working directory we create an alias the working directory and use that. It should fail without the fix. So we need test only branch or patch - Assigned to yash.rode
- 🇮🇳India yash.rode pune
In
ComposerInspector.php
I removed realpath() for $package['path'], because it is returning false for the cases when the directory did not exists. and with that build tests are still running. - Issue was unassigned.
- Status changed to Needs review
over 1 year ago 9:06am 5 April 2023 - Assigned to yash.rode
- Status changed to Needs work
over 1 year ago 5:15pm 5 April 2023 - 🇺🇸United States phenaproxima Massachusetts
The general change makes sense but I think we could do this a touch more cleanly.
- Assigned to kunal.sachdev
- Status changed to Needs review
over 1 year ago 7:44am 6 April 2023 - Assigned to phenaproxima
- Status changed to RTBC
over 1 year ago 1:32pm 6 April 2023 -
phenaproxima →
committed 355be049 on 3.0.x authored by
tedbow →
Issue #3351883 by yash.rode, tedbow, phenaproxima: \Drupal\...
-
phenaproxima →
committed 355be049 on 3.0.x authored by
tedbow →
- 🇺🇸United States phenaproxima Massachusetts
Thanks for the reviews! Glad my thing ultimately made sense; sorry I wasn't able to explain it more clearly.
- Issue was unassigned.
- Status changed to Fixed
over 1 year ago 1:49pm 20 April 2023 Automatically closed - issue fixed for 2 weeks with no activity.