- Issue created by @phenaproxima
- @phenaproxima opened merge request.
- Assigned to tedbow
- Status changed to Needs review
over 1 year ago 4:47pm 31 March 2023 - Status changed to Needs work
over 1 year ago 4:53pm 31 March 2023 - πΊπΈUnited States tedbow Ithaca, NY, USA
So you did option 2. I don't think we can expect calling code to keep up with Composer changes. otherwise they would have to update for any changes like this
I would be in favor of 4
- πΊπΈUnited States phenaproxima Massachusetts
I think that it makes sense to continue to expect the calling code to know the "shape" of the value. In this case, the callers know that it's either a boolean (in ComposerSettingsValidator), or a boolean|array (ComposerPluginsValidator). They know what they need, so it makes sense that they should be expected to normalize it.
- Status changed to Needs review
over 1 year ago 2:57pm 3 April 2023 - Status changed to RTBC
over 1 year ago 5:20pm 3 April 2023 -
phenaproxima β
committed 1f8516c0 on 3.0.x
Issue #3351594 by phenaproxima: As of Composer 2.5.5, `composer config`...
-
phenaproxima β
committed 1f8516c0 on 3.0.x
- Issue was unassigned.
- Status changed to Fixed
over 1 year ago 5:40pm 3 April 2023 - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Woah that is unexpected! But β¦ it makes things more consistent in the future, so yay!
What am I'm missing here is a
@todo
to remove the helper once 2.5.5 is required. π Add @todo for reverting a work-around once Composer 2.5.5 is required Fixed did that too for the other place where we have a <2.5.5-specific work-around. - Assigned to phenaproxima
- Status changed to Needs work
over 1 year ago 7:59am 19 April 2023 - πΊπΈUnited States phenaproxima Massachusetts
Do we still need this to be open? We now require 2.5.5 at a minimum, and have removed all workarounds, as far as I know.
- Issue was unassigned.
- Status changed to Fixed
over 1 year ago 10:45am 5 July 2023 - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
π Drop support for Composer 2.2, require Composer >=2.5.5 Fixed indeed made this obsolete on May 26, which was accelerated due to other circumstances.
It's just that for 1.5 month we should have done #11, but bridge under the water! π
Automatically closed - issue fixed for 2 weeks with no activity.