- 🇩🇪Germany Harlor Berlin
Thx for working on this!
We need to address at least these 3 things:
1. Please add/update the doc-bocks.
2. addPlural should have a multiple implementation as well.
3. Update the README and explain how one can add multiple translations strings in a deploy_hook. - Status changed to Needs review
over 1 year ago 6:01am 27 April 2023 I added multiple methods for the plural and adjusted code for the singular version. The README also got some adjustments, so has the documentation.
- Status changed to Needs work
over 1 year ago 11:02am 5 May 2023 - 🇩🇪Germany Harlor Berlin
I think this goes in the right direction.
Can you please add tests for each usecase?
- 🇩🇪Germany Harlor Berlin
Also I still see typos like: addMPluralTranslation.
- @lotharneumann opened merge request.
- Status changed to Needs review
over 1 year ago 11:24am 2 June 2023 - Status changed to Needs work
over 1 year ago 7:34am 5 June 2023 - Status changed to Needs review
over 1 year ago 10:55am 9 June 2023 I changed the code according to the requests. Tell me if anything is missing or not right, please.
- Status changed to RTBC
over 1 year ago 9:46am 13 June 2023 - Status changed to Fixed
over 1 year ago 9:55am 16 June 2023 Automatically closed - issue fixed for 2 weeks with no activity.