- Issue created by @bunty oberoi
- First commit to issue fork.
- @ranjit1032002 opened merge request.
- Status changed to Needs review
over 1 year ago 12:39pm 31 March 2023 - 🇮🇳India Ranjit1032002
Created MR!4 Drupal 10 compatibility fixes, Please review.
Thank You. - Assigned to Akshay kashyap
- 🇮🇳India Akshay kashyap
Hi @Ranjit1032002,
Verified and tested MR !4 on Drupal 10.1.x Applied cleanly
Testing Steps:-
1. Install Drupal 10.1.x version.
2. git clone branch '8.x-1.x' bootstrap-business. git
2. Applied MR !4 drupal-git/drupal/themes/contrib/bootstrap-business.
3. Checked the changes difference using git diff
4. But Not able to set it as the default theme it showsRequires: classy (missing)This theme requires the base theme classy to operate correctly.
Testing result:
bootstrap-business Theme not compatible with Drupal 10.1.x
Here I have attached the screenshots. - Status changed to Needs work
over 1 year ago 5:02am 12 April 2023 - 🇮🇳India Akshay kashyap
Created a patch for Drupal 10 compatibility fixes, please review.
Thank You. - Status changed to Needs review
over 1 year ago 5:20am 12 April 2023 - Status changed to Needs work
over 1 year ago 9:10am 14 April 2023 - 🇮🇳India bunty oberoi
Hi Akshay,
Verified and tested Patch #8 on Drupal 10.1.x
Testing Steps:-
1. Install Drupal 10.1.x version.
2. git clone --branch '8.x-1.x' https://git.drupalcode.org/project/bootstrap-business.git
2. Applied Patch #8 /Documents/drupal/themes/contrib/bootstrap-business.
3. Checked the changes difference using git diff
4. Installed theme and set it as default.Testing result:
bootstrap-business Theme is compatible with Drupal 10.1.x with some worning please check the code below.oberoi@oberoi-H510M-S2:~/Documents/projects/drupal/themes/contrib/bootstrap-business$ git apply -v Port-Bootstrap-business-theme-drupal9-drupal10-3351513-8.patch Checking patch bootstrap_business.info.yml... Checking patch templates/block--system-menu-block.html.twig... Checking patch theme-settings.php... Port-Bootstrap-business-theme-drupal9-drupal10-3351513-8.patch:107: new blank line at EOF. + Applied patch bootstrap_business.info.yml cleanly. Applied patch templates/block--system-menu-block.html.twig cleanly. Applied patch theme-settings.php cleanly. warning: 1 line adds whitespace errors.
Please fix the Drupal coding standards.
- 🇮🇳India ravi kant Jaipur
This is duplicate ticket of https://www.drupal.org/project/bootstrap_business/issues/3296675 📌 Automated Drupal 10 compatibility fixes Needs review
I have created a Patch in other ticket.
https://www.drupal.org/files/issues/2023-10-11/3296675-3.patch →