- Issue created by @solideogloria
- Status changed to Needs review
over 1 year ago 11:28pm 11 April 2023 - πΊπΈUnited States jrockowitz Brooklyn, NY
This regression is caused by Drupal core's CKEditor wrapping the string in P tags. Since we want to fully support CKEditor via Drupal 6.2.x, we need to support the P tags.
- Status changed to RTBC
over 1 year ago 3:04pm 12 April 2023 Works well. The patch applies and the update correctly removed all the extra properties.
-
jrockowitz β
authored f4b1a990 on 6.2.x
Issue #3351348 by jrockowitz: '#multiple__no_items_message' added to...
-
jrockowitz β
authored f4b1a990 on 6.2.x
- Status changed to Fixed
over 1 year ago 3:46pm 18 April 2023 - π¬π§United Kingdom sergiur London, UK
When I run this update I get
Error: Class "WebformYaml" not found in webform_post_update_ckeditor01() (line 113 of /app/web/modules/contrib/webform/webform.post_update.php).
Does this need touse Drupal\webform\Utility\WebformYaml;
or maybe I'm missing something since the patch applied for others? Do you have the same problem if you clear the cache before running the updates?
- π¬π§United Kingdom sergiur London, UK
Yup, same issue even after cache clear (I clear caches before updb out of habit xD)
What version of webform are you using? I'm using 6.2.0-beta5, and my webform/webform.post_update.php file does not have a line 113, nor does it have a
webform_post_update_ckeditor01()
function.It just has this, which doesn't have a reference to WebformYaml:
/** * Move from custom CKEditor to hidden 'webform_default' text format. */ function webform_post_update_ckeditor() { $config = \Drupal::configFactory()->getEditable('webform.settings'); if (empty($config->get('html_editor.element_format'))) { $config->set('html_editor.element_format', WebformHtmlEditor::DEFAULT_FILTER_FORMAT); } if (empty($config->get('html_editor.mail_format'))) { $config->set('html_editor.mail_format', WebformHtmlEditor::DEFAULT_FILTER_FORMAT); } $config->save(); _webform_update_html_editor(); }
- π¬π§United Kingdom sergiur London, UK
beta5 is from January, this fix is in the latest 6.2 dev version
I don't have dev installed. I just have the patch via Composer. So it's possible your issue is actually related to another update, namely the
webform_post_update_ckeditor01()
function you mentioned. You should open a separate new issue.- π¬π§United Kingdom sergiur London, UK
The update function references this issue ID so I assumed it was introduced here:
/** * Issue #3351348: '#multiple__no_items_message' added to every field. */ function webform_post_update_ckeditor01() {
Ah okay. I'm using patch #2. The actual commit is slightly different.
I switched to using the commit patch. I had no issues running the DB update.
There isn't an equivalent of a manual registry rebuild. According to this post, you may need to restart php-fpm, then try running the updates.
- π¨π³China jungle Chongqing, China
Made a patch for #6 see π Error: Class "WebformYaml" not found in webform_post_update_ckeditor01() Fixed
Automatically closed - issue fixed for 2 weeks with no activity.