- Issue created by @ghuygens
- 🇧🇪Belgium ghuygens
Place these files in src/Plugin/Validation/Constraint
https://github.com/symfony/symfony/blob/6.2/src/Symfony/Component/Valida...
https://github.com/symfony/symfony/blob/6.2/src/Symfony/Component/Valida... - 🇧🇪Belgium ghuygens
If we move to drupal10 completely this can be removed again or maybe needs to be updated with most recent symfony version.
- 🇳🇱Netherlands joshahubbers
Thanks for your patch! I will test it. Do you have examples of IBANs that don't validate well?
- 🇳🇱Netherlands joshahubbers
Ah, I see some additions 2 months ago in the "blame" sheet.
- 🇳🇱Netherlands joshahubbers
I have been thinking about this and I don't like the idea of putting Symfony files in the module, since Symfony is included when Drupal is installed. I propose to make a new version that is only for d10 and above that uses this. Is that ok?
- 🇧🇪Belgium ghuygens
That is OK form me as drupal 10 is symfony 6. Another reason to upgrade.
- 🇳🇱Netherlands joshahubbers
Uhm, thinking further... if we move to D10, we need to change nothing, because just as you said: That's Symfony 6, so the IBAN validator is automatically upgraded. So, sorry, but I will close this issue than without any changes... Feel free to reopen it if you disagree.
- Status changed to Closed: won't fix
over 1 year ago 8:35am 18 April 2023